Bug 31929

Summary: On vendor edit page options are not aligned
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Lucas Gass (lukeg) <lucas>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: minor    
Priority: P5 - low CC: gmcharlt, lucas
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Bug Depends on: 30952    
Bug Blocks:    
Attachments: Screenshot of vendor edit page
Bug 31929: Radio inputs need to be outside of respective labels
Bug 31929: Radio inputs need to be outside of respective labels

Description Katrin Fischer 2022-10-23 12:54:51 UTC
Created attachment 142464 [details]
Screenshot of vendor edit page

When editing a vendor, the radio boxed options at the bottom are not aligend right. The second option is displayed a little abvoe the first option. (see screenshot)
Comment 1 Lucas Gass (lukeg) 2022-10-24 18:24:07 UTC
The radio inputs should not be nested inside of their labels.
Comment 2 Lucas Gass (lukeg) 2022-10-24 18:27:52 UTC
Created attachment 142547 [details] [review]
Bug 31929: Radio inputs need to be outside of respective labels

1. Apply patch
2. Go to Acquisitions and edit or create a vendor.
3. Look at the radio buttons in the Ordering information section.
4. They should be properly aligned.
5. Make sure the form still works and you can save changes.
Comment 3 Katrin Fischer 2022-10-24 18:30:07 UTC
Don't forget to set assignee!
Comment 4 Katrin Fischer 2022-10-24 18:33:07 UTC
Created attachment 142549 [details] [review]
Bug 31929: Radio inputs need to be outside of respective labels

1. Apply patch
2. Go to Acquisitions and edit or create a vendor.
3. Look at the radio buttons in the Ordering information section.
4. They should be properly aligned.
5. Make sure the form still works and you can save changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-10-24 18:34:06 UTC
Nice logical fix, thx Lucas!
PQA directly.
Comment 6 Tomás Cohen Arazi (tcohen) 2022-10-24 18:45:16 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!