Bug 31952

Summary: Sending an empty system preference search breaks layout
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Lucas Gass <lucas>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, lucas, victor
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks: 32065    
Attachments: Bug 31952: Fix broken layout on system pref search
Bug 31952: Fix broken layout on system pref search
Bug 31952: Fix broken layout on system pref search
Bug 31952: (QA follow-up) Fix capitalization: Local Use

Description Katrin Fischer 2022-10-24 15:24:15 UTC
When sending the form for searching system preferences empty, the layout breaks a bit.

One of the system preference headings will float to the right at the same height as the h1 heading.
Comment 1 Lucas Gass 2022-10-24 21:49:11 UTC
This is the same problem as Bug 31886. I neglected to update local_use.pref
Comment 2 Lucas Gass 2022-10-24 21:51:52 UTC
Created attachment 142576 [details] [review]
Bug 31952: Fix broken layout on system pref search

TO test:
1. Do an empty system pref search
2. Layout is broken.
3. Apply patch, restart_all
4. Do another empty system pref search, the layout should be fixed.
Comment 3 David Nind 2022-10-25 01:42:35 UTC
Created attachment 142593 [details] [review]
Bug 31952: Fix broken layout on system pref search

TO test:
1. Do an empty system pref search
2. Layout is broken.
3. Apply patch, restart_all
4. Do another empty system pref search, the layout should be fixed.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Katrin Fischer 2022-10-26 22:24:46 UTC
Created attachment 142691 [details] [review]
Bug 31952: Fix broken layout on system pref search

TO test:
1. Do an empty system pref search
2. Layout is broken.
3. Apply patch, restart_all
4. Do another empty system pref search, the layout should be fixed.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-10-26 22:24:50 UTC
Created attachment 142692 [details] [review]
Bug 31952: (QA follow-up) Fix capitalization: Local Use

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2022-10-27 12:44:54 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Victor Grousset/tuxayo 2022-10-30 02:47:49 UTC
It seems there is still some invalid YAML:
https://jenkins.koha-community.org/view/master/job/Koha_Master_U18/1639/consoleText

Weird that only one build fails about this.

Failing files touched by this ticket and bug 31886