Bug 31955

Summary: Add page-section to additional fields (admin)
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Lucas Gass (lukeg) <lucas>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, lucas
Version: MainKeywords: Academy
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Bug Depends on: 30952    
Bug Blocks: 31757    
Attachments: Bug 31955: Add page-section div to additional-fields.tt
Bug 31955: Add page-section div to additional-fields.tt

Description Katrin Fischer 2022-10-24 16:20:52 UTC
The table for configured additional fields should have some background (page-section).
Comment 1 Lucas Gass (lukeg) 2022-10-24 17:47:27 UTC
Created attachment 142539 [details] [review]
Bug 31955: Add page-section div to additional-fields.tt

To test:
1. Apply patch
2. Look at Administration > Additional fields.
3. Each of the 4 tables should have a page-section div around it:

    Order baskets (aqbasket)
    Subscriptions (subscription)
    Account lines (credit) (accountlines:credit)
    Account lines (debit) (accountlines:debit)

Note: There are some indentation changes.
Comment 2 Katrin Fischer 2022-10-24 18:14:09 UTC
This is great. Wondering: should we have a page-section here too?
http://localhost:8081/cgi-bin/koha/admin/additional-fields.pl
Comment 3 Katrin Fischer 2022-10-24 18:15:53 UTC
Created attachment 142546 [details] [review]
Bug 31955: Add page-section div to additional-fields.tt

To test:
1. Apply patch
2. Look at Administration > Additional fields.
3. Each of the 4 tables should have a page-section div around it:

    Order baskets (aqbasket)
    Subscriptions (subscription)
    Account lines (credit) (accountlines:credit)
    Account lines (debit) (accountlines:debit)

Note: There are some indentation changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2022-10-24 18:16:17 UTC
Moving to PQA directly!
Comment 5 Tomás Cohen Arazi (tcohen) 2022-10-24 18:45:24 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!