Bug 31962

Summary: Add tooltip to 'configure' on datatable controls
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Katrin Fischer <katrin.fischer>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.03
Bug Depends on: 31861    
Bug Blocks:    
Attachments: Bug 31962: Add tooltip to 'configure' on datatable controls
Bug 31962: Add tooltip to 'configure' on datatable controls
Bug 31962: Add tooltip to 'configure' on datatable controls

Description Katrin Fischer 2022-10-24 19:56:31 UTC
When you hover over Export and print, there is a tooltip in the form of a speech bubble showing on top. But if you hover over configure, a normal tooltip shows below.

To test:
* Go to a patron account
* Check out any book
* Hover over table controls
Comment 1 Katrin Fischer 2023-01-06 21:07:25 UTC
Created attachment 145106 [details] [review]
Bug 31962: Add tooltip to 'configure' on datatable controls

This makes sure that the last button on the datatable controls
also has a tooltip, like the other buttons.

To test:
* Without the patch:
* Check out an item and look at the table of checkouts
* Look at the detail page of a record with at least one item
* Confirm that the 'configure' button doesn't have a tooltip appear
  as a bubble like the other buttons
* Apply patch
* Restart_all and reload pages
* Make sure the styling of the 'configure' tooltip now matches that
  of the other buttons
Comment 2 David Nind 2023-01-07 11:11:00 UTC
Created attachment 145133 [details] [review]
Bug 31962: Add tooltip to 'configure' on datatable controls

This makes sure that the last button on the datatable controls
also has a tooltip, like the other buttons.

To test:
* Without the patch:
* Check out an item and look at the table of checkouts
* Look at the detail page of a record with at least one item
* Confirm that the 'configure' button doesn't have a tooltip appear
  as a bubble like the other buttons
* Apply patch
* Restart_all and reload pages
* Make sure the styling of the 'configure' tooltip now matches that
  of the other buttons

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2023-01-31 12:47:32 UTC
Created attachment 145851 [details] [review]
Bug 31962: Add tooltip to 'configure' on datatable controls

This makes sure that the last button on the datatable controls
also has a tooltip, like the other buttons.

To test:
* Without the patch:
* Check out an item and look at the table of checkouts
* Look at the detail page of a record with at least one item
* Confirm that the 'configure' button doesn't have a tooltip appear
  as a bubble like the other buttons
* Apply patch
* Restart_all and reload pages
* Make sure the styling of the 'configure' tooltip now matches that
  of the other buttons

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2023-01-31 12:47:58 UTC
Nice consistency improvement, no regressions found.

Passing QA, Thanks Katrin.
Comment 5 Tomás Cohen Arazi 2023-01-31 13:48:11 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-01-31 18:10:50 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.