| Summary: | SIP server rejects passwords ending in non-alphanumeric characters | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | SIP2 | Assignee: | Bugs List <koha-bugs> |
| Status: | NEW --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | jonathan.druart, kyle, magnus, marion.durand, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
To recreate: 1 - Set a patron's password to secret* 2 - Attempt a patron information request via the sip clip emulator: perl misc/sip_cli_emulator.pl -su term1 -sp term1 -l CPL -a localhost -p 6001 -m patron_information --patron ballard --password secret* 3 - It fails? 4 - Set password to secret*s 5 - Repeat perl misc/sip_cli_emulator.pl -su term1 -sp term1 -l CPL -a localhost -p 6001 -m patron_information --patron ballard --password secret*s 6 - It succeeeds Offending line(s) appears to be: 366 $buffer =~ s/^\s*[^A-z0-9]+//s; 367 # Every line must start with a "real" character. Not whitespace, control chars, etc. 368 $buffer =~ s/[^A-z0-9]+$//s; 369 370 # Same for the end. Note this catches the problem some clients have sending empty fields at the end, like |||