Summary: | build_holds_queue.pl should check to see if the RealTime syspref is on | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <wizzyrea> |
Component: | System Administration | Assignee: | Kyle M Hall <kyle> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, kyle, lucas, michaela.sieber |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.07
|
|
Attachments: |
Bug 31995: build_holds_queue.pl should check to see if the RealTimeHoldsQueue syspref is on
Bug 31995: build_holds_queue.pl should check to see if the RealTimeHoldsQueue syspref is on Bug 31995: build_holds_queue.pl should check to see if the RealTimeHoldsQueue syspref is on Bug 31995: (QA follow-up) Add 'system preference' to help text Bug 31995: build_holds_queue.pl should check to see if the RealTimeHoldsQueue syspref is on [v22.05] |
Description
Liz Rea
2022-10-26 17:02:31 UTC
Created attachment 142725 [details] [review] Bug 31995: build_holds_queue.pl should check to see if the RealTimeHoldsQueue syspref is on The real time hold queue and the build_holds_queue.pl jobs are not 100% compatible in that we should not be running the cron if the real time queue is enabled, this could lead to double server work. It would be good to have a check in build_holds_queue for the RealTimeHoldsQueue syspref and not run the job if the preference is enabled. There might be times when we'd want to force a run of this job without changing the syspref. To that end we would also want a flag for this job so that system administrators could force the job from the command line if required, overriding this limitation. Test Plan: 1) Apply this patch 2) Try run misc/cronjobs/holds/build_holds_queue.pl with the -h/--help and -m/--man options 3) Disable RealTimeHoldsQueue 4) Run with no options, should succeed 5) Enable RealTimeHoldsQueue 6) Run with no options, should display a message and not rebuild the holds queue 7) Run again with the -f/--force option, should succeed Created attachment 142798 [details] [review] Bug 31995: build_holds_queue.pl should check to see if the RealTimeHoldsQueue syspref is on The real time hold queue and the build_holds_queue.pl jobs are not 100% compatible in that we should not be running the cron if the real time queue is enabled, this could lead to double server work. It would be good to have a check in build_holds_queue for the RealTimeHoldsQueue syspref and not run the job if the preference is enabled. There might be times when we'd want to force a run of this job without changing the syspref. To that end we would also want a flag for this job so that system administrators could force the job from the command line if required, overriding this limitation. Test Plan: 1) Apply this patch 2) Try run misc/cronjobs/holds/build_holds_queue.pl with the -h/--help and -m/--man options 3) Disable RealTimeHoldsQueue 4) Run with no options, should succeed 5) Enable RealTimeHoldsQueue 6) Run with no options, should display a message and not rebuild the holds queue 7) Run again with the -f/--force option, should succeed Signed-off-by: David Nind <david@davidnind.com> Created attachment 143016 [details] [review] Bug 31995: build_holds_queue.pl should check to see if the RealTimeHoldsQueue syspref is on The real time hold queue and the build_holds_queue.pl jobs are not 100% compatible in that we should not be running the cron if the real time queue is enabled, this could lead to double server work. It would be good to have a check in build_holds_queue for the RealTimeHoldsQueue syspref and not run the job if the preference is enabled. There might be times when we'd want to force a run of this job without changing the syspref. To that end we would also want a flag for this job so that system administrators could force the job from the command line if required, overriding this limitation. Test Plan: 1) Apply this patch 2) Try run misc/cronjobs/holds/build_holds_queue.pl with the -h/--help and -m/--man options 3) Disable RealTimeHoldsQueue 4) Run with no options, should succeed 5) Enable RealTimeHoldsQueue 6) Run with no options, should display a message and not rebuild the holds queue 7) Run again with the -f/--force option, should succeed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 143017 [details] [review] Bug 31995: (QA follow-up) Add 'system preference' to help text We often get asked where something can be found in setting, adding the hint that RealTimeHoldsQueue is a system preference is hopefully helpful here. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Love to see this script improved - most of this patch is documentation :) Pushed to master for 22.11. Nice work everyone, thanks! Patchset will not apply cleanly to 22.05.x branch, please rebase if needed Created attachment 143864 [details] [review] Bug 31995: build_holds_queue.pl should check to see if the RealTimeHoldsQueue syspref is on [v22.05] The real time hold queue and the build_holds_queue.pl jobs are not 100% compatible in that we should not be running the cron if the real time queue is enabled, this could lead to double server work. It would be good to have a check in build_holds_queue for the RealTimeHoldsQueue syspref and not run the job if the preference is enabled. There might be times when we'd want to force a run of this job without changing the syspref. To that end we would also want a flag for this job so that system administrators could force the job from the command line if required, overriding this limitation. Test Plan: 1) Apply this patch 2) Try run misc/cronjobs/holds/build_holds_queue.pl with the -h/--help and -m/--man options 3) Disable RealTimeHoldsQueue 4) Run with no options, should succeed 5) Enable RealTimeHoldsQueue 6) Run with no options, should display a message and not rebuild the holds queue 7) Run again with the -f/--force option, should succeed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 31995: (QA follow-up) Add 'system preference' to help text We often get asked where something can be found in setting, adding the hint that RealTimeHoldsQueue is a system preference is hopefully helpful here. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Thanks Kyle! Pushed to 22.05.x for upcoming 22.05.07 release |