Summary: | Accessibility: Order search results has two h1 headings | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.05
|
|
Circulation function: | |||
Attachments: |
Bug 32003: Add page-section to order search results and fix heading hierarchy
Bug 32003: Add page-section to order search results and fix heading hierarchy Bug 32003: Add page-section to order search results and fix heading hierarchy Bug 32003: Add page-section to order search results and fix heading hierarchy Bug 32003: Add page-section to order search results and fix heading hierarchy |
Description
Katrin Fischer
2022-10-26 21:00:59 UTC
Created attachment 144924 [details] [review] Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area Created attachment 144945 [details] [review] Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Thanks, Lucas :) Page section added by Bug 32616 already. Heading still needs to be fixed. Created attachment 147675 [details] [review] Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> rebased for current master Created attachment 148148 [details] [review] Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Created attachment 148644 [details] [review] Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x |