Bug 32006

Summary: Add page-section to local use system preference tab (admin)
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff interfaceAssignee: Lucas Gass <lucas>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: david, gmcharlt, lucas
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/acqui/parcel.pl?invoiceid=1
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 30952    
Bug Blocks: 31757    
Attachments: Bug 32006: Add page-section for local use system preferences
Bug 32006: Add page-section for local use system preferences
Bug 32006: Add page-section for local use system preferences

Description Katrin Fischer 2022-10-26 22:16:22 UTC

    
Comment 1 Lucas Gass 2022-11-02 22:16:27 UTC
Local use works a bit differently than the rest of the prefs so I think we need to add the page-section for this directly in systempreferences.tt
Comment 2 Lucas Gass 2022-11-02 22:21:55 UTC
Created attachment 143045 [details] [review]
Bug 32006: Add page-section for local use system preferences

To test:
1. Go to the System preferences > Local use
2. Notice there is no page section and the table has much more space on the left than other system preference sections
3. Apply patch
4. Look again, the extra space on the left should be eliminated and the page-section should be added.
5. Use an HTML validator to spot errors.

Note: I elimiated the inline style on the table that set the width to 80%. I don't see why that is needed but if it is we should be using CSS to do so.
Comment 3 David Nind 2022-11-03 01:39:33 UTC
Created attachment 143054 [details] [review]
Bug 32006: Add page-section for local use system preferences

To test:
1. Go to the System preferences > Local use
2. Notice there is no page section and the table has much more space on the left than other system preference sections
3. Apply patch
4. Look again, the extra space on the left should be eliminated and the page-section should be added.
5. Use an HTML validator to spot errors.

Note: I elimiated the inline style on the table that set the width to 80%. I don't see why that is needed but if it is we should be using CSS to do so.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2022-11-03 01:40:34 UTC
Testing notes:

- Used https://www.gueury.com/mozilla/index.html as an HTML validator for Firefox.

- Lots of warnings, but no errors.
Comment 5 Katrin Fischer 2022-11-03 09:45:04 UTC
Created attachment 143070 [details] [review]
Bug 32006: Add page-section for local use system preferences

To test:
1. Go to the System preferences > Local use
2. Notice there is no page section and the table has much more space on the left than other system preference sections
3. Apply patch
4. Look again, the extra space on the left should be eliminated and the page-section should be added.
5. Use an HTML validator to spot errors.

Note: I elimiated the inline style on the table that set the width to 80%. I don't see why that is needed but if it is we should be using CSS to do so.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2022-11-03 12:56:11 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!