Summary: | Some Letters template variables are not available to certain notice types | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Notices | Assignee: | Henri-Damien LAURENT <henridamien> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | bchurch, colin.campbell, cookie.wolfrom, dgrobani, jcamins, jwagner, m.de.rooy, smoreland |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Patch with contents of branch
Signed-off patch |
Description
Chris Cormack
2010-05-21 01:07:38 UTC
I've taken the mods from the branch Jane refers to and rebased them against master. They are in the branch bug_3203 at git://github.com/colinsc/koha.git I'd be grateful if someone could test them. (In reply to comment #1) > I've taken the mods from the branch Jane refers to and rebased them against > master. They are in the branch bug_3203 at git://github.com/colinsc/koha.git > I'd be grateful if someone could test them. Could you attach a patch file to this bug? Created attachment 3173 [details] [review] Patch with contents of branch Squashed the branch into a single commit Thanks. Patch applies. Will test it now.. Have spent some time on this one. With a circulation notice, PREDUE, items.content is replaced but the additional items fields are not replaced. As you can see with some extra debug prints, the parseletter routine is not called for items at all. [marcel@RKM004 testclone]$ ./misc/cronjobs/advance_notices.pl -c -m 3 -v -n getting upcoming due issues at ./misc/cronjobs/advance_notices.pl line 119. found 1 issues at ./misc/cronjobs/advance_notices.pl line 121. examining 197 upcoming due items at ./misc/cronjobs/advance_notices.pl line 140. MR:25 parseletter: table=borrowers parseletter: table=branches parseletter: table=biblio parseletter: table=biblioitems 2011-02-18 3 stoleti nizozemsk kresby 1400-1700 : 439 C 40 Aachen, Hans von, <<items.barcode>> <<items.itemcallnumber>> <<items.date_due>> <<items.issuedate>> An additional question about the new lines on pk2 CHECKIN in Letters.pm: Code seems to make an improper[?] use of this fourth parameter. But I wonder where this fourth parameter is passed to the routine. Couldn't find it at first glance. Created attachment 3444 [details] [review] Signed-off patch Patch pushed, please test Do I overlook something here? Patch and signoff are quite DIFFerent ??? There was a new patch from Ian Walls that Jared Camins-Esakov signed-off. This bug is mentioned in: Bug 3203: ACCTDETAIL notices don't parse branches or borrowers tokens http://lists.koha-community.org/pipermail/koha-patches/2011-March/014239.html There have been no further reports of problems so I am marking this bug resolved. |