Summary: | Sidebar and footer style improvements on suggestions page | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Attachments: |
Bug 32038: Sidebar and footer style improvements on suggestions page
Bug 32038: Sidebar and footer style improvements on suggestions page Bug 32038: Sidebar and footer style improvements on suggestions page |
Description
Owen Leonard
2022-10-28 16:56:23 UTC
Created attachment 142783 [details] [review] Bug 32038: Sidebar and footer style improvements on suggestions page This patch makes some changes to the suggestions template in order to make the sidebar filter form and bulk action table footer forms more usable and readable. Some global changes to <fieldset class="brief"> style are made. To test, apply the patch and rebuild the staff interface CSS. - Go to Suggestions. - Confirm that the sidebar contains two sections: Organize by and Filter by. - Test that the links under "Filter by" work to expand and collapse the different sections (bibliographic, suggestion, and acquisition). - Below the table of existing suggestions you should see the section "Change selected suggestions." - Each form should look good, with labels in bold above each form field, with "primary" style submit buttons. - Because some global styles have been modified, check that fieldsets with the class "brief" are still displayed correctly in other areas: - In sidebar forms: Patrons, Acquisitions order and invoice searches, overdues and holds to pull in Circulation. - In other areas: The Quick spine label creator; the upload plugin form; the calendar's add holiday form. Created attachment 142789 [details] [review] Bug 32038: Sidebar and footer style improvements on suggestions page This patch makes some changes to the suggestions template in order to make the sidebar filter form and bulk action table footer forms more usable and readable. Some global changes to <fieldset class="brief"> style are made. To test, apply the patch and rebuild the staff interface CSS. - Go to Suggestions. - Confirm that the sidebar contains two sections: Organize by and Filter by. - Test that the links under "Filter by" work to expand and collapse the different sections (bibliographic, suggestion, and acquisition). - Below the table of existing suggestions you should see the section "Change selected suggestions." - Each form should look good, with labels in bold above each form field, with "primary" style submit buttons. - Because some global styles have been modified, check that fieldsets with the class "brief" are still displayed correctly in other areas: - In sidebar forms: Patrons, Acquisitions order and invoice searches, overdues and holds to pull in Circulation. - In other areas: The Quick spine label creator; the upload plugin form; the calendar's add holiday form. Signed-off-by: David Nind <david@davidnind.com> It is certainly an improvement! Two things I am not completely sure about: 1) When you open up the filters there is a grey line on the side. I think that one is not really needed. 2) The update options look much better, but it feels like it would be nice to have some kind of separation. Created attachment 142806 [details] [review] Bug 32038: Sidebar and footer style improvements on suggestions page This patch makes some changes to the suggestions template in order to make the sidebar filter form and bulk action table footer forms more usable and readable. Some global changes to <fieldset class="brief"> style are made. To test, apply the patch and rebuild the staff interface CSS. - Go to Suggestions. - Confirm that the sidebar contains two sections: Organize by and Filter by. - Test that the links under "Filter by" work to expand and collapse the different sections (bibliographic, suggestion, and acquisition). - Below the table of existing suggestions you should see the section "Change selected suggestions." - Each form should look good, with labels in bold above each form field, with "primary" style submit buttons. - Because some global styles have been modified, check that fieldsets with the class "brief" are still displayed correctly in other areas: - In sidebar forms: Patrons, Acquisitions order and invoice searches, overdues and holds to pull in Circulation. - In other areas: The Quick spine label creator; the upload plugin form; the calendar's add holiday form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Enhancement will not be backported to 22.05.x series |