Summary: | OPAC and staff interface results page do not honor SyndeticsCoverImageSize | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Tools | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | minor | ||
Priority: | P5 - low | CC: | arthur.suzuki, barbara.johnson, jacob.omara |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.06,22.05.13
|
|
Circulation function: | |||
Attachments: |
Bug 32041: Enforce SyndeticsCoverImageSize everywhere
Bug 33168: (follow-up) Swap spaces for tabs Bug 32041: Enforce SyndeticsCoverImageSize everywhere |
Description
Lucas Gass (lukeg)
2022-10-29 21:19:17 UTC
I think this is being handled correctly, the results pages should always show the smaller thumbnail type images. The system preference description should be updated. I've had many libraries complain about the small size/blurriness of cover images on the results page. We should make Syndetics cover images honor the 'SyndeticsCoverImageSize' in any place where they are displayed. Created attachment 149388 [details] [review] Bug 32041: Enforce SyndeticsCoverImageSize everywhere This patch add the SyndeticsCoverImageSize to the folling pages: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt To test: 1. Turn on SyndeticsCoverImages and SyndeticsEnabled. 2. Check the staff results page and make sure you can change the image size via SyndeticsCoverImageSize. 3. Check the OPAC results page. 4. Turn on 'OPACShelfBrowser' and make sure you change the image sizes within the shelf browser. 5. Test the OPAC checkout history page. ( opac-readingrecord.tt ) 6. Have a checkout and an overdue to test the 2 tables on the OPAC summary pahe. ( opac-user.tt ) Everything about the patch worked great except for step #4. Even though I had OPACShelfBrowser turned on I could never find any records in the OPAC that would display the shelf browser so I couldn't test that part. (In reply to Barbara Johnson from comment #4) > Everything about the patch worked great except for step #4. Even though I > had OPACShelfBrowser turned on I could never find any records in the OPAC > that would display the shelf browser so I couldn't test that part. Did your items have an item.itemcallnumber? They did not. Let me add that and try again. That worked. The images do appear in the correct sizes in the shelf browser. However, when scrolling back and forth through the titles in the shelf browser, once I go back to look at the original images they now display the ‘No cover image available’ graphic instead of the cover images. It doesn’t seem to be holding on to the images. (In reply to Barbara Johnson from comment #7) > That worked. The images do appear in the correct sizes in the shelf > browser. However, when scrolling back and forth through the titles in the > shelf browser, once I go back to look at the original images they now > display the ‘No cover image available’ graphic instead of the cover images. > It doesn’t seem to be holding on to the images. Is that behavior that you can recreate with or without this patch? If so, perhaps we should file a separate bug? I’m not sure. Is there a way to un-apply a patch on a sandbox? Or do I need to start from scratch with a new one? (In reply to Barbara Johnson from comment #9) > I’m not sure. Is there a way to un-apply a patch on a sandbox? Or do I > need to start from scratch with a new one? You can't remove the patch, but you can make another sandbox without entering a bug number to get an installation without any chances for comparison. Created attachment 149759 [details] [review] Bug 33168: (follow-up) Swap spaces for tabs Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> I retested and can confirm that the images not being retained when scrolling through the shelf browser exists without this patch. It has already been filed as bug 29993. Everything else about this patch works great. (In reply to Barbara Johnson from comment #12) > I retested and can confirm that the images not being retained when scrolling > through the shelf browser exists without this patch. It has already been > filed as bug 29993. Everything else about this patch works great. Thanks Barbara, I have also added a patch for Bug 29993. Trusting Barbara and Lucas here for testing with Syndetics credentials. I have carefully reviewed the patch and compared it to how other syndetics file names were built previously and it all appears to match up. Created attachment 150140 [details] [review] Bug 32041: Enforce SyndeticsCoverImageSize everywhere This patch add the SyndeticsCoverImageSize to the folling pages: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt To test: 1. Turn on SyndeticsCoverImages and SyndeticsEnabled. 2. Check the staff results page and make sure you can change the image size via SyndeticsCoverImageSize. 3. Check the OPAC results page. 4. Turn on 'OPACShelfBrowser' and make sure you change the image sizes within the shelf browser. 5. Test the OPAC checkout history page. ( opac-readingrecord.tt ) 6. Have a checkout and an overdue to test the 2 tables on the OPAC summary pahe. ( opac-user.tt ) Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Backported to 22.05.x for upcoming 22.05.13 doesn't apply on 21.11 please provide a backport if needed |