| Summary: | Calendar adding holidays repeated | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Tools | Assignee: | Laura Escamilla <Laura.escamilla> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, Laura.escamilla, lucas, salah.ghedda |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38357 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.04,22.11.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 32048: Added clear cache routine to delete_holiday_range_repeatable
Bug 32048: Added clear cache routine to delete_holiday_range_repeatable Bug 32048: Added clear cache routine to delete_holiday_range_repeatable |
||
|
Description
Nick Clemens (kidclamp)
2022-10-31 10:07:25 UTC
Created attachment 154885 [details] [review] Bug 32048: Added clear cache routine to delete_holiday_range_repeatable To test: 1 - Enter a holiday repeated yearly on a range from the 1st of the month to the 5th 2 - Delete it 3 - Add a new holiday from the 20th to the 25th 4 - When saved, the holiday from the 1st to the 5th is also added again. 5 - Apply patch and restart_all. 6 - Repeat steps 1-3. Notice that the holiday from the 1st to the 5th is no longer added and it has properly been cleared from the cache. 7 - Sign off! :D Created attachment 155497 [details] [review] Bug 32048: Added clear cache routine to delete_holiday_range_repeatable Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed Off Created attachment 155766 [details] [review] Bug 32048: Added clear cache routine to delete_holiday_range_repeatable When adding and deleting holidays, holidays might return unexpectedly. To test: 1 - Enter a holiday repeated yearly on a range from the 1st of the month to the 5th 2 - Delete it 3 - Add a new holiday from the 20th to the 25th 4 - When saved, the holiday from the 1st to the 5th is also added again. 5 - Apply patch and restart_all. 6 - Repeat steps 1-3. Notice that the holiday from the 1st to the 5th is no longer added and it has properly been cleared from the cache. 7 - Sign off! :D Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice commit messages please! Not sure if this can be unit tested, but we do have a change in a core module. Pushed to master for 23.11. Nice work everyone, thanks! Pushed to 23.05.x for 23.05.04 Nice work everyone! Pushed to oldstable for 22.11.x |