Bug 32064

Summary: Add missing test to template permission calculation
Product: Koha Reporter: David Cook <dcook>
Component: Test SuiteAssignee: David Cook <dcook>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 31389    
Bug Blocks:    
Attachments: Bug 32064: Add test data for all report subpermissions
Bug 32064: Add test data for all report subpermissions
Bug 32064: Add test data for all report subpermissions

Description David Cook 2022-11-02 00:42:03 UTC
Bug 31389 refactored how permissions are calculated for the templates. Today I realized there was 1 missing test to test that all subpermission authorizations are set when the top level permission is set.
Comment 1 David Cook 2022-11-02 00:46:04 UTC
Created attachment 142904 [details] [review]
Bug 32064: Add test data for all report subpermissions

This patch adds test data to prove that all authorizations
for subpermissions are set when only a top level flag is set.

To test:
0) Apply patch
1) prove ./t/Koha/Auth/Permissions.t
Comment 2 David Nind 2022-11-02 04:41:32 UTC
Created attachment 142913 [details] [review]
Bug 32064: Add test data for all report subpermissions

This patch adds test data to prove that all authorizations
for subpermissions are set when only a top level flag is set.

To test:
0) Apply patch
1) prove ./t/Koha/Auth/Permissions.t

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Cook 2022-11-02 05:29:19 UTC
Thanks, David :)
Comment 4 Katrin Fischer 2022-11-02 13:18:03 UTC
Created attachment 142976 [details] [review]
Bug 32064: Add test data for all report subpermissions

This patch adds test data to prove that all authorizations
for subpermissions are set when only a top level flag is set.

To test:
0) Apply patch
1) prove ./t/Koha/Auth/Permissions.t

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-11-03 12:56:17 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!