Summary: | Consistent classes for primary buttons: Acquisitions | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | lucas, martin.renvoize, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 32067 | ||
Attachments: |
Bug 32070: Consistent classes for primary buttons: Acquisitions
Bug 32070: Consistent classes for primary buttons: Acquisitions Bug 32070: Consistent classes for primary buttons: Acquisitions |
Description
Owen Leonard
2022-11-02 11:43:28 UTC
Created attachment 142925 [details] [review] Bug 32070: Consistent classes for primary buttons: Acquisitions This patch makes changes the button markup in Acquisitions templates so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view pages in Acquisitions to confirm that everything looks correct. In most cases there are no visible changes. Looking here... Created attachment 142954 [details] [review] Bug 32070: Consistent classes for primary buttons: Acquisitions This patch makes changes the button markup in Acquisitions templates so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view pages in Acquisitions to confirm that everything looks correct. In most cases there are no visible changes. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 142987 [details] [review] Bug 32070: Consistent classes for primary buttons: Acquisitions This patch makes changes the button markup in Acquisitions templates so that all submit buttons and any buttons that should should be styled as primary buttons have the Bootstrap class "btn btn-primary." To test, apply the patch and view pages in Acquisitions to confirm that everything looks correct. In most cases there are no visible changes. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Passing QA as this just improves markup consistency.. What I'm less sure about is having all the actions buttons on the closed basketgroups table be primary.. it feels like primary should be saved for 'the main action on a page'.. can we really have a whole table full of 'main actions'? One for the new style guide I reckon. I agree. I simply applied classes according to the existing markup, which consisted of input[type='submit'] which would have had the primary appearance regardless of the added class. Pushed to master for 22.11. Nice work everyone, thanks! |