Bug 32087

Summary:	Consistent classes for primary buttons: Course reserves
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	enhancement
Priority:	P5 - low	CC:	david, testopia
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00
Circulation function:
Bug Depends on:
Bug Blocks:	32067
Attachments:	Bug 32087: Consistent classes for primary buttons: Course reserves Bug 32087: Consistent classes for primary buttons: Course reserves Bug 32087: Consistent classes for primary buttons: Course reserves

Description Owen Leonard 2022-11-03 12:08:48 UTC

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary buttons:

This patch will update buttons in course reserve templates so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes.

In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary.

Comment 1 Owen Leonard 2022-11-03 12:13:55 UTC

Created attachment 143085 [details] [review]
Bug 32087: Consistent classes for primary buttons: Course reserves

This patch makes changes the button markup in course reserves templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view course reserves pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Comment 2 David Nind 2022-11-06 04:19:11 UTC

Created attachment 143301 [details] [review]
Bug 32087: Consistent classes for primary buttons: Course reserves

This patch makes changes the button markup in course reserves templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view course reserves pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david@davidnind.com>

Comment 3 David Nind 2022-11-06 04:21:30 UTC

Testing notes (using KTD).

1. These changed templates accessed from: Home page > Course reserves.
   
2. I tested by:
   - Reviewing the patch - <input type="submit"... becomes <input type="submit" class="btn btn-primary"...
   - Listing the templates in koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/ and splitting into two lists - those changed and those not changed
   - Working out how to access them
   - Creating screenshots and putting them in a document (I haven't attached this, but am happy to)
   - Applying the patch (+ flush_memcached, restart_all, and cleared browser cache)
   - Going through the list of files again: compared to original screenshot taken, then noted whether thre is a visible change or not
   - Noting any questions - these don't affect the sign off for this bug
   
3. Files changed:
   - add_items-step1.tt (No visible change. Course reserves > [select or create a course] > Add reserves > [First step - barcode or biblionumber])
   - add_items-step2.tt (No visible change. Next step when adding a course reserve - continues from step 1 - [select check boxes, add staff or public notes])
   - batch_add_items.tt (No visible change. Course reserves > [select or create a course] > Batch add reserves)
   - batch_rm_items.tt (No visible change. Course reserves > Batch remove reserves)
   - course.tt (No visible change. Course reserves > New course)

4. Files not changed:
   - course-details.tt (Course reserves > [select or create a course])
   - course-reserves.tt (Course reserves) (course reserves home page)
   - invalid-course.tt (Not sure how to trigger - has no buttons anyway)

5. File count check:
   - Number of files in folder: 8
   - Number of files listed: 8 (5 changed in this patch)

Questions/notes: none

Comment 4 Katrin Fischer 2022-11-09 13:11:35 UTC

Created attachment 143505 [details] [review]
Bug 32087: Consistent classes for primary buttons: Course reserves

This patch makes changes the button markup in course reserves templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."

To test, apply the patch and view course reserves pages to confirm
that everything looks correct. In most cases there are no visible
changes.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Tomás Cohen Arazi (tcohen) 2022-11-09 17:40:13 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!