Bug 32098

Summary:	Consistent classes for primary buttons: Clubs and rotating collections
Product:	Koha	Reporter:	Owen Leonard <oleonard>
Component:	Templates	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	testopia, tomascohen
Version:	Main	Keywords:	rel_22_11_candidate
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	22.11.00
Circulation function:
Bug Depends on:
Bug Blocks:	32067
Attachments:	Bug 32098: Consistent classes for primary buttons: Clubs and rotating collections Bug 32098: Consistent classes for primary buttons: Clubs and rotating collections Bug 32098: Consistent classes for primary buttons: Clubs and rotating collections

Description Owen Leonard 2022-11-03 15:05:06 UTC

As part of Bug 32067 - [OMNIBUS] Consistent classes for submit and/or primary buttons:

This patch will update buttons in clubs and rotating collections templates so that buttons which are currently styled as primary buttons will have the the "btn btn-primary" classes.

In some places, the classes have been added to buttons which were not input[type='submit'] but which should be styled as primary.

Comment 1 Owen Leonard 2022-11-03 15:11:29 UTC

Created attachment 143126 [details] [review]
Bug 32098: Consistent classes for primary buttons: Clubs and rotating collections

This patch makes changes the button markup in clubs and rotating
collections templates so that all submit buttons and any buttons that
should should be styled as primary buttons have the Bootstrap class "btn
btn-primary."

To test, apply the patch and view patron clubs and rotating collections
pages to confirm that everything looks correct. In most cases there are
no visible changes.

Comment 2 Katrin Fischer 2022-11-10 18:23:46 UTC

Created attachment 143700 [details] [review]
Bug 32098: Consistent classes for primary buttons: Clubs and rotating collections

This patch makes changes the button markup in clubs and rotating
collections templates so that all submit buttons and any buttons that
should should be styled as primary buttons have the Bootstrap class "btn
btn-primary."

To test, apply the patch and view patron clubs and rotating collections
pages to confirm that everything looks correct. In most cases there are
no visible changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 3 Tomás Cohen Arazi (tcohen) 2022-11-14 12:35:47 UTC

Created attachment 143825 [details] [review]
Bug 32098: Consistent classes for primary buttons: Clubs and rotating collections

This patch makes changes the button markup in clubs and rotating
collections templates so that all submit buttons and any buttons that
should should be styled as primary buttons have the Bootstrap class "btn
btn-primary."

To test, apply the patch and view patron clubs and rotating collections
pages to confirm that everything looks correct. In most cases there are
no visible changes.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Comment 4 Tomás Cohen Arazi (tcohen) 2022-11-14 12:41:06 UTC

Pushed to master for 22.11.

Nice work everyone, thanks!