Summary: | Add padding to floating toolbars | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 30952 | ||
Bug Blocks: | |||
Attachments: |
Patron entry form floating toolbar
Bug 32101: Add padding to floating toolbars Bug 32101: Add padding to floating toolbars Bug 32101: Add padding to floating toolbars |
Created attachment 143147 [details] [review] Bug 32101: Add padding to floating toolbars This patch makes a slight change to the CSS controling the appearance of floating toolbars. In some cases the lack of padding around the toolbar elements made it look awkward. To test, apply the patch and rebuild the staff interface CSS. View various pages to confirm that the toolbar looks correct when you scroll down and the toolbar "sticks" to the top of the browser viewport. For example: - Patrons -> Search results - Patrons -> Add/edit patron - Catalog -> Advanced search form - Administration -> Preferences - Authorities -> Add/edit authority - Cataloging -> Add/edit MARC record - Catalog -> Item search form Created attachment 143150 [details] [review] Bug 32101: Add padding to floating toolbars This patch makes a slight change to the CSS controling the appearance of floating toolbars. In some cases the lack of padding around the toolbar elements made it look awkward. To test, apply the patch and rebuild the staff interface CSS. View various pages to confirm that the toolbar looks correct when you scroll down and the toolbar "sticks" to the top of the browser viewport. For example: - Patrons -> Search results - Patrons -> Add/edit patron - Catalog -> Advanced search form - Administration -> Preferences - Authorities -> Add/edit authority - Cataloging -> Add/edit MARC record - Catalog -> Item search form Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Thanks Owen, I've noticed this but neglected to file a bug. Glad to see it fixed. *** Bug 31944 has been marked as a duplicate of this bug. *** Better but still misaligned IMO. https://snipboard.io/XE7LgI.jpg Created attachment 143609 [details] [review] Bug 32101: Add padding to floating toolbars This patch makes a slight change to the CSS controling the appearance of floating toolbars. In some cases the lack of padding around the toolbar elements made it look awkward. To test, apply the patch and rebuild the staff interface CSS. View various pages to confirm that the toolbar looks correct when you scroll down and the toolbar "sticks" to the top of the browser viewport. For example: - Patrons -> Search results - Patrons -> Add/edit patron - Catalog -> Advanced search form - Administration -> Preferences - Authorities -> Add/edit authority - Cataloging -> Add/edit MARC record - Catalog -> Item search form Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! |
Created attachment 143145 [details] Patron entry form floating toolbar In several cases floating toolbars have no padding, making the layout seem awkward. See attached screenshot.