Bug 32106

Summary: Formatting issues - accounting details form when receiving items
Product: Koha Reporter: David Nind <david>
Component: AcquisitionsAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low Keywords: Academy
Version: master   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Screenshot - Receiving order form - formatting

Description David Nind 2022-11-04 02:26:15 UTC
Created attachment 143163 [details]
Screenshot - Receiving order form - formatting

When receiving an order, there are some minor formatting issues for two fields on the accounting details form (see the attached screenshot):
- Retail price: no space after value and the opening bracket; no space between comma and tax exclusive (or tax inclusive, depending on the vendor setting)
- Budgeted cost: no space after value and the opening bracket

This requires changes to koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt to fix.

To replicate:*
1. Add an order to a basket for a vendor (Acquisitions > Manage orders > click search > select My Basket (for My Vendor) > Add to basket).
2. Close the basket (select 'Close basket' from the basket page).
3. Receive shipments for the vendor (Acquisitions > Manage orders > click search (shows My Basket for My Vendor) > Receive shipments > Enter an invoice number > Next).
4. Click receive for an item in My Basket.
5. Note the formatting issues on the accounting details form for these fields:
   - Retail price: no space after value and the opening bracket; no space between comma and tax exclusive (or tax inclusive)
   - Budgeted cost: no space after value and the opening bracket
6. On another tab, edit the vendor so that for 'list prices' and 'invoice prices' the 'include tax' option is selected.
7. Refresh the tab for receiving items.
8. Note the same formatting issues as in step 5.

* Using koha-testing-docker (KTD) there is one vendor (My Vendor) with an empty basket (My Basket) already setup.