Summary: | Cannot schedule a pickup at the OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | critical | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall |
Version: | unspecified | Keywords: | rel_22_11_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 30718, 30650 | ||
Bug Blocks: | 31261 | ||
Attachments: |
Bug 32111: Remove disabled from date input for curbside pickup
Bug 32111: Remove disabled from date input for curbside pickup Bug 32111: Remove disabled from date input for curbside pickup Bug 32111: Remove disabled from date input for curbside pickup |
Description
Jonathan Druart
2022-11-04 12:29:57 UTC
Created attachment 143181 [details] [review] Bug 32111: Remove disabled from date input for curbside pickup The date input is always disabled and it's not possible to select or enter a date. git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true" I don't really know what's happening here, but it's impossible to interact with the date widget if the input is disabled when it's initialized. The solution I have here is to play with hide/show instead of disabled. Other suggestions welcome. Test plan: Schedule a curbside pickup from the OPAC and confirm that the date input is working as expected. Created attachment 143184 [details] [review] Bug 32111: Remove disabled from date input for curbside pickup The date input is always disabled and it's not possible to select or enter a date. git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true" I don't really know what's happening here, but it's impossible to interact with the date widget if the input is disabled when it's initialized. The solution I have here is to play with hide/show instead of disabled. Other suggestions welcome. Test plan: Schedule a curbside pickup from the OPAC and confirm that the date input is working as expected. Signed-off-by: David Nind <david@davidnind.com> Created attachment 143185 [details] [review] Bug 32111: Remove disabled from date input for curbside pickup The date input is always disabled and it's not possible to select or enter a date. git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true" I don't really know what's happening here, but it's impossible to interact with the date widget if the input is disabled when it's initialized. The solution I have here is to play with hide/show instead of disabled. Other suggestions welcome. Test plan: Schedule a curbside pickup from the OPAC and confirm that the date input is working as expected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 143492 [details] [review] Bug 32111: Remove disabled from date input for curbside pickup The date input is always disabled and it's not possible to select or enter a date. git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true" I don't really know what's happening here, but it's impossible to interact with the date widget if the input is disabled when it's initialized. The solution I have here is to play with hide/show instead of disabled. Other suggestions welcome. Test plan: Schedule a curbside pickup from the OPAC and confirm that the date input is working as expected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! |