| Summary: | Add ID to check-out default help message dialog to allow customization | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mona Panchaud <m+koha> |
| Component: | Self checkout | Assignee: | Mona Panchaud <m+koha> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | arthur.suzuki, lucas, m+koha, martin.renvoize, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.01,22.05.09, 21.11.16
|
|
| Circulation function: | |||
| Attachments: |
Proposed patch to add div with id to allow hiding it and customize with SCOMainUserBlock.
Bug 32115: Add ID to check-out default help message dialog to allow customization Bug 32115: Add ID to check-out default help message dialog to allow customization |
||
|
Description
Mona Panchaud
2022-11-05 19:34:11 UTC
Created attachment 143299 [details] [review] Proposed patch to add div with id to allow hiding it and customize with SCOMainUserBlock. Created attachment 144089 [details] [review] Bug 32115: Add ID to check-out default help message dialog to allow customization This adds a div with the id attribute selfcheckdefaulthelpmessage to the first paragraph of the web based self check help page. To test: * Enable WebBasedSelfCheck * Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC * Log in and open help * Verify by looking at the source code, that the first paragraph starting with "If this is your first time..." now has an id. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Hi Mona, I believe this has been your first patch for Koha? Welcome! :) Yes, this is my first patch as I only recently started to work at a library :) What are the next steps to get the patch merged? This is signed-off now, which means you passed the first round of testing. Now it' s waiting for the QA team to have a look. Created attachment 144497 [details] [review] Bug 32115: Add ID to check-out default help message dialog to allow customization This adds a div with the id attribute selfcheckdefaulthelpmessage to the first paragraph of the web based self check help page. To test: * Enable WebBasedSelfCheck * Go to: /cgi-bin/koha/sco/sco-main.pl in the OPAC * Log in and open help * Verify by looking at the source code, that the first paragraph starting with "If this is your first time..." now has an id. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Welcome aboard Mona, The patch is nice and simple and works well.. I'd love to see this block moved to a News block as that way it becomes easier for staff to change in the staff client and have translations working.. but that can be another bug. No regressions found and the QA script is happy. Passing QA. Congratulations on your first patch, now it's over to the Release Manager to get it pushed :) Pushed to master for 23.05. Nice work everyone, thanks! Strictly this one is an enhancement, but as it's so unobtrusive I'm opting to backport it.. welcome to the stables Mona :) Nice work everyone! Pushed to 22.11.x for the next release I tend to agree with Martin. Adding a class/ID is unobtrusive and helpful. Opting to backport, welcome to the oldstables Mona. :) Backported to 22.05.x for upcoming 22.05.09 applied to 21.11.x for 21.11.16 Not backported to 21.05.x |