Bug 32122

Summary: Wrong permissions check on item circulation alerts
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Staff interfaceAssignee: Nick Clemens (kidclamp) <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Bug Depends on: 14391    
Bug Blocks:    
Attachments: Bug 32122: Correct permissions check on item circulation alerts
Bug 32122: Correct permissions check on item circulation alerts

Description Nick Clemens (kidclamp) 2022-11-07 13:56:08 UTC
Bug 14391 added granular permissions for the administration module, however, there was a mismatch in the check on item circulation alerts and the new permission
Comment 1 Nick Clemens (kidclamp) 2022-11-07 13:58:44 UTC
Created attachment 143370 [details] [review]
Bug 32122: Correct permissions check on item circulation alerts

This patch changes the check from 'item_circ_alerts' to 'manage_item_circ_alerts'

To test:
1 - Give an account catalogue and manage_item_circ_alerts permissions
2 - Log in to staff client iwht this account
3 - Browse to Admin->Item circulation alerts
4 - Error, you do not have permission to view this page
5 - Apply patch
6 - Restart all
7 - Browse to page agian, success!
Comment 2 Nick Clemens (kidclamp) 2022-11-07 14:08:49 UTC
Straight to QA, minor and easy fix
Comment 3 Tomás Cohen Arazi 2022-11-07 14:18:39 UTC
Created attachment 143372 [details] [review]
Bug 32122: Correct permissions check on item circulation alerts

This patch changes the check from 'item_circ_alerts' to 'manage_item_circ_alerts'

To test:
1 - Give an account catalogue and manage_item_circ_alerts permissions
2 - Log in to staff client iwht this account
3 - Browse to Admin->Item circulation alerts
4 - Error, you do not have permission to view this page
5 - Apply patch
6 - Restart all
7 - Browse to page agian, success!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2022-11-07 14:21:00 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!