Summary: | Buttons must inherit Bootstrap size classes | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
Circulation function: | |||
Bug Depends on: | 32044 | ||
Bug Blocks: | 32071 | ||
Attachments: |
Bug 32148: Buttons must inherit Bootstrap size classes
Bug 32148: Buttons must inherit Bootstrap size classes Bug 32148: Buttons must inherit Bootstrap size classes |
Description
Owen Leonard
2022-11-09 14:07:53 UTC
Created attachment 143517 [details] [review] Bug 32148: Buttons must inherit Bootstrap size classes This patch removes global font and padding settings which were overriding the Bootstrap classes we use to change the size of Bootstrap buttons. The font and padding settings are moved to the CSS which covers button which are not styled as Bootstrap buttons. To test, apply the patch and view pages where buttons are styled with different Bootstrap size classes: - Circulation -> Check out: - The "Check out" button, the "Show checkouts" button, Renew buttons in the footer. - Patrons -> Patron details -> Edit buttons in each section. - Patrons home -> Buttons in sidebar filter - Catalog -> Bibliographic details -> Item details Created attachment 143596 [details] [review] Bug 32148: Buttons must inherit Bootstrap size classes This patch removes global font and padding settings which were overriding the Bootstrap classes we use to change the size of Bootstrap buttons. The font and padding settings are moved to the CSS which covers button which are not styled as Bootstrap buttons. To test, apply the patch and view pages where buttons are styled with different Bootstrap size classes: - Circulation -> Check out: - The "Check out" button, the "Show checkouts" button, Renew buttons in the footer. - Patrons -> Patron details -> Edit buttons in each section. - Patrons home -> Buttons in sidebar filter - Catalog -> Bibliographic details -> Item details Created attachment 143607 [details] [review] Bug 32148: Buttons must inherit Bootstrap size classes This patch removes global font and padding settings which were overriding the Bootstrap classes we use to change the size of Bootstrap buttons. The font and padding settings are moved to the CSS which covers button which are not styled as Bootstrap buttons. To test, apply the patch and view pages where buttons are styled with different Bootstrap size classes: - Circulation -> Check out: - The "Check out" button, the "Show checkouts" button, Renew buttons in the footer. - Patrons -> Patron details -> Edit buttons in each section. - Patrons home -> Buttons in sidebar filter - Catalog -> Bibliographic details -> Item details Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! |