Summary: | Uncertain prices has 2 level 1 headings | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | minor | ||
Priority: | P5 - low | CC: | kyle |
Version: | Main | Keywords: | Academy, accessibility |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04
|
|
Circulation function: | |||
Attachments: |
Bug 32159: Fix heading hierarchy on uncertain prices page
Bug 32159: Fix heading hierarchy on uncertain prices page Bug 32159: Fix heading hierarchy on uncertain prices page Bug 32159: Fix heading hierarchy on uncertain prices page |
Description
Katrin Fischer
2022-11-09 23:18:18 UTC
Created attachment 146455 [details] [review] Bug 32159: Fix heading hierarchy on uncertain prices page This makes sure we don't have 2 level 1 headings on the same page. To test: * Create a new order for a basket in the acq module, make sure the uncertain price checkbox is checked bevor saving * Go to uncertain prices using the link in the toolbar on the basket summary page * Verify that there are 2 almost identical h1 headings and a "/ Fax:" reference at the top of the page * Apply patch * Verify that we now have one level 1 heading and a level 2 heading for each section. The fax reference is also gone. Created attachment 146646 [details] [review] Bug 32159: Fix heading hierarchy on uncertain prices page This makes sure we don't have 2 level 1 headings on the same page. To test: * Create a new order for a basket in the acq module, make sure the uncertain price checkbox is checked bevor saving * Go to uncertain prices using the link in the toolbar on the basket summary page * Verify that there are 2 almost identical h1 headings and a "/ Fax:" reference at the top of the page * Apply patch * Verify that we now have one level 1 heading and a level 2 heading for each section. The fax reference is also gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 146907 [details] [review] Bug 32159: Fix heading hierarchy on uncertain prices page This makes sure we don't have 2 level 1 headings on the same page. To test: * Create a new order for a basket in the acq module, make sure the uncertain price checkbox is checked bevor saving * Go to uncertain prices using the link in the toolbar on the basket summary page * Verify that there are 2 almost identical h1 headings and a "/ Fax:" reference at the top of the page * Apply patch * Verify that we now have one level 1 heading and a level 2 heading for each section. The fax reference is also gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 147207 [details] [review] Bug 32159: Fix heading hierarchy on uncertain prices page This makes sure we don't have 2 level 1 headings on the same page. To test: * Create a new order for a basket in the acq module, make sure the uncertain price checkbox is checked bevor saving * Go to uncertain prices using the link in the toolbar on the basket summary page * Verify that there are 2 almost identical h1 headings and a "/ Fax:" reference at the top of the page * Apply patch * Verify that we now have one level 1 heading and a level 2 heading for each section. The fax reference is also gone. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x |