| Summary: | Random biblionumber passed when clicking 'Z3950 SRU/Search' from the search results in staff client | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Staff interface | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | critical | ||
| Priority: | P5 - low | CC: | gmcharlt, lnilsson, rudolfbyker |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 32172: Remove biblionumber param from Z3950 popup on results
Bug 32172: Remove biblionumber param from Z3950 popup on results Bug 32172: Remove biblionumber param from Z3950 popup on results |
||
Created attachment 143728 [details] [review] Bug 32172: Remove biblionumber param from Z3950 popup on results This param is not defined in routine, who knows whereit comes from To test: 1 - Enable coce and coce intranet, select all providers: https://coce.bywatersolutions.com 2 - Search on staff client 3 - Click Z3950 search 4 - Note url contains a random biblionumber 5 - Apply patch 6 - Repeat 7 - No biblionumber Created attachment 143739 [details] [review] Bug 32172: Remove biblionumber param from Z3950 popup on results This param is not defined in routine, who knows whereit comes from To test: 1 - Enable coce and coce intranet, select all providers: https://coce.bywatersolutions.com 2 - Search on staff client 3 - Click Z3950 search 4 - Note url contains a random biblionumber 5 - Apply patch 6 - Repeat 7 - No biblionumber Signed-off-by: David Nind <david@davidnind.com> Created attachment 143951 [details] [review] Bug 32172: Remove biblionumber param from Z3950 popup on results This param is not defined in routine, who knows whereit comes from To test: 1 - Enable coce and coce intranet, select all providers: https://coce.bywatersolutions.com 2 - Search on staff client 3 - Click Z3950 search 4 - Note url contains a random biblionumber 5 - Apply patch 6 - Repeat 7 - No biblionumber Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! |
The code for Z3950 popup: 393 /* this function open a popup to search on z3950 server. */ 394 function PopupZ3950() { 395 if( strQuery ){ 396 window.open("/cgi-bin/koha/cataloguing/z3950_search.pl?biblionumber=" + biblionumber + strQuery,"z3950sear ch",'width=740,height=450,location=yes,toolbar=no,scrollbars=yes,resize=yes'); 397 } 398 } 399 Picks a random biblionumber variable Seems to get defined when images are enabled, presumably from verify_cover_images We shouldn't ever be replacing a biblio from the results page, so lets just remove it