Bug 32183

Summary: Purchase suggestions for logged in patron - doesn't display suggestions made by everyone
Product: Koha Reporter: David Nind <david>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: caroline.cyr-la-rose, januszop, pmis
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20207
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description David Nind 2022-11-11 23:53:12 UTC 
If OPACViewOthersSuggestions is set to 'Show', for a logged in patron they can only see their own suggestions - not all suggestions as expected.

This is working correctly on 22.05.x, but is not working on the current master.

To replicate on the current master:
1. Set AnonSuggestions to 'Allow'.
2. Set OPACViewOthersSuggestions to 'Show'.
3. On the OPAC, when not logged in, add a purchase suggestion.
4. On the OPAC, log in as a patron and make a purchase suggestion.
5. Change OPACViewOthersSuggestions to "Don't show".
6. Under Your account > Purchase suggestions, you can only see your own suggestions (as expected).
6. Change OPACViewOthersSuggestions set to "Show".
7. Under Your account > Purchase suggestions, after the "Search for" input field there is a dropdown list with options:
   7.1 Select "Suggested by me" and press "Go": the patron's own suggestion(s) are correctly shown.
   7.2 Select "Suggested by anyone" and press 'Go': it DOESN'T show all suggestions.

Identified when testing bug 20207.
Comment 1 Caroline Cyr La Rose 2023-02-22 21:58:19 UTC 
I confirm this is still valid and even when AnonSuggestions is off (not sure if you had that turned on to facilitate the test?).