Bug 32194

Summary:	"Can be guarantee" value should show uppercase "No"
Product:	Koha	Reporter:	Andrew Fuerste-Henry <andrew>
Component:	Staff interface	Assignee:	David Nind <david>
Status:	CLOSED FIXED	QA Contact:	Katrin Fischer <katrin.fischer>
Severity:	minor
Priority:	P5 - low	CC:	david, gmcharlt
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:	This fixes the display of the patron categories "Can be guarantee" column so that "No" values have a capital "N". Previously, "no" values were shown with a lowercase "n".	Version(s) released in:	23.05.00,22.11.01
Circulation function:
Bug Depends on:	12446
Bug Blocks:
Attachments:	Bug 32194: Capitalize "No" values for the patron categories "Can be guarantee" column Bug 32194: Capitalize "No" values for the patron categories "Can be guarantee" column

Description Andrew Fuerste-Henry 2022-11-14 16:18:42 UTC

On the patron categories page, there's a column for "can be guaranteee," that shows a yes or no value. Except it shows "Yes" with a capital "Y" and "no" with a lowercase "n." Per our general style guidelines, that "no" should be capitalized.

Comment 1 David Nind 2022-11-14 21:39:45 UTC

Created attachment 143875 [details] [review]
Bug 32194: Capitalize "No" values for the patron categories "Can be guarantee" column

This fixes the display of the patron categories "Can be guarantee"
column so that "No" values have a capital "N".

Test plan:
1. Go to Administration > Patrons and circulation > Patron categories.
2. Note that for the "Can be guarantee" column, it shows "Yes" values
   with a capital "Y" and "no" values with a lowercase "n".
3. Apply the patch.
4. Refresh the page.
5. Note that any "No" values now have a capital "N".
6. Sign off D:

Signed-off-by: David Nind <david@davidnind.com>

Comment 2 Katrin Fischer 2022-11-14 21:50:15 UTC

Created attachment 143878 [details] [review]
Bug 32194: Capitalize "No" values for the patron categories "Can be guarantee" column

This fixes the display of the patron categories "Can be guarantee"
column so that "No" values have a capital "N".

Test plan:
1. Go to Administration > Patrons and circulation > Patron categories.
2. Note that for the "Can be guarantee" column, it shows "Yes" values
   with a capital "Y" and "no" values with a lowercase "n".
3. Apply the patch.
4. Refresh the page.
5. Note that any "No" values now have a capital "N".
6. Sign off D:

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 3 Katrin Fischer 2022-11-14 21:51:00 UTC

Might have to wait because of string freeze.

Comment 4 David Nind 2022-11-14 23:24:08 UTC

This relates to a new feature added to 22.11 in Bug 12446 - Enable an adult to have a guarantor, so only affects master.

Comment 5 Katrin Fischer 2022-12-07 21:33:03 UTC

I had missed to set this to PQA, but also checked it again now :)

Comment 6 Tomás Cohen Arazi (tcohen) 2022-12-13 12:48:21 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 7 Martin Renvoize (ashimema) 2022-12-15 13:48:45 UTC

Nice work everyone!

Pushed to 22.11.x for the next release