Bug 32213

Summary: Reindent item search fields template
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: martin.renvoize, tomascohen
Version: MainKeywords: rel_22_11_candidate
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.05.00, 22.11.01
Circulation function:
Bug Depends on: 32126    
Bug Blocks:    
Attachments: Bug 32213: Reindent item search fields templates
Bug 32213: Reindent item search fields templates
Bug 32213: Reindent item search fields templates
Bug 32213: Reindent item search fields templates

Description Katrin Fischer 2022-11-15 16:11:37 UTC
The template file items_search_fields.tt is hard to read and is not indented correctly. It would be nice to fix this in order to make the template easier to read and avoid errors in the future (see bug 32126)
Comment 1 Owen Leonard 2022-11-17 15:50:45 UTC
Created attachment 144010 [details] [review]
Bug 32213: Reindent item search fields templates

This patch reindents three item search field templates so that they have
consistent indentation.

To test, apply the patch and go to Administration -> Item search fields.

Test all aspects of viewing, adding, and deleting item search fields.
Everything should look correct and work correctly.
Comment 2 David Nind 2022-11-17 19:26:27 UTC
Created attachment 144031 [details] [review]
Bug 32213: Reindent item search fields templates

This patch reindents three item search field templates so that they have
consistent indentation.

To test, apply the patch and go to Administration -> Item search fields.

Test all aspects of viewing, adding, and deleting item search fields.
Everything should look correct and work correctly.

Signed-off-by: David <david@davidnind.com>
Comment 3 Katrin Fischer 2022-11-17 19:59:05 UTC
Created attachment 144035 [details] [review]
Bug 32213: Reindent item search fields templates

This patch reindents three item search field templates so that they have
consistent indentation.

To test, apply the patch and go to Administration -> Item search fields.

Test all aspects of viewing, adding, and deleting item search fields.
Everything should look correct and work correctly.

Signed-off-by: David <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-11-29 12:06:40 UTC
Created attachment 144314 [details] [review]
Bug 32213: Reindent item search fields templates

This patch reindents three item search field templates so that they have
consistent indentation.

To test, apply the patch and go to Administration -> Item search fields.

Test all aspects of viewing, adding, and deleting item search fields.
Everything should look correct and work correctly.

Signed-off-by: David <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Edit: changed intendation on a tiny bit
Comment 5 Tomás Cohen Arazi (tcohen) 2022-11-29 12:08:53 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Martin Renvoize (ashimema) 2022-11-29 14:08:45 UTC
Pushed to 22.11.x for 22.11.01 release.

Thanks everyone.