Bug 32218

Summary: Rephrase: Allow OPAC access to users from this domain to login with this identity provider.
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: RESOLVED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: aleisha, dcook, lucas, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Attachments: Bug 32218: Update string grammer in identity-providers.tt
Bug 32218: Update string grammar in identity-providers.tt
Bug 32218: Update string grammar in identity-providers.tt
Bug 32218: Update string grammar in identity-providers.tt

Description Katrin Fischer 2022-11-15 22:24:07 UTC
Found while translating:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:204
Allow OPAC access to users from this domain to login with this identity provider.

Maybe this was meant?

Allow users of this domain to log into the OPAC using this identity provider.
Comment 1 David Cook 2022-11-15 22:39:18 UTC
Certainly sounds like a good rephrase to me
Comment 2 Katrin Fischer 2022-11-16 00:10:44 UTC
There is another, similar one:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:212
Allow staff access to users from this domain to login with this identity provider.
Comment 3 Koha Training Catalyst 2024-07-25 22:36:09 UTC
Created attachment 169618 [details] [review]
Bug 32218: Update string grammer in identity-providers.tt

Adiministration>Identity Providers>New identity provider under allow OPAC the language string was updated.
Comment 4 Chris Cormack 2024-07-25 23:09:38 UTC
Created attachment 169623 [details] [review]
Bug 32218: Update string grammar in identity-providers.tt

Adiministration>Identity Providers>New identity provider under allow OPAC the language string was updated.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 5 Chris Cormack 2024-07-25 23:11:00 UTC
Created attachment 169624 [details] [review]
Bug 32218: Update string grammar in identity-providers.tt

Adiministration>Identity Providers>New identity provider under allow OPAC the language string was updated.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 6 Owen Leonard 2024-07-26 16:50:50 UTC
Created attachment 169765 [details] [review]
Bug 32218: Update string grammar in identity-providers.tt

Adiministration > Identity Providers > New identity provider under allow
OPAC the language string was updated.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 7 Katrin Fischer 2024-09-02 10:23:23 UTC
QA'd by RM. String change.
Comment 8 Katrin Fischer 2024-09-02 14:11:10 UTC
It looks like I got confused with bug 8855 somehow and falsely attributed this patch to Jennifer Sutton in the commit and pushed it. I sincerely apologize for that confusion.

Aleisha or Wainui, do you know who wrote this patch and if they would like to be attributed?

I think a revert would not fix in git history, but happy to do it if you think it would be the right thing to do. Also open to other suggestions.
Comment 9 Aleisha Amohia 2024-09-02 20:50:00 UTC
This patch was written by Michael Nixon. I did show him how to 'take credit' for the fix but since he hasn't followed the steps maybe he doesn't mind.
Comment 10 Katrin Fischer 2024-09-03 08:11:20 UTC
(In reply to Aleisha Amohia from comment #9)
> This patch was written by Michael Nixon. I did show him how to 'take credit'
> for the fix but since he hasn't followed the steps maybe he doesn't mind.

Should we leave as is? I am not sure if a revert/re-push (with the original email) won't make statistics more confusing, but happy to do it if you think we should.
Comment 11 Aleisha Amohia 2024-09-03 20:52:23 UTC
I think it's okay to leave as-is, no need to create extra weirdness/work for yourself. Thank you though!