Bug 32223

Summary: package.json script paths too specific
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Tomás Cohen Arazi (tcohen) <tomascohen>
Severity: normal    
Priority: P5 - low CC: oleonard, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00
Circulation function:
Bug Depends on:    
Bug Blocks: 32224    
Attachments: Bug 32223: Remove node_modules/.bin from package.json
Bug 32223: Remove node_modules/.bin from package.json

Description Jonathan Druart 2022-11-16 08:09:14 UTC
"build": "node_modules/.bin/gulp build",

We should not specify the node_modules/.bin part if the env is correctly configured.
Comment 1 Jonathan Druart 2022-11-16 08:10:11 UTC
Created attachment 143942 [details] [review]
Bug 32223: Remove node_modules/.bin from package.json

We should not specify the node_modules/.bin part if the env is correctly configured.
Comment 2 Jonathan Druart 2022-11-16 08:12:35 UTC
To test:
pull the latest ktd images (to get /kohadevbox/node_modules)
remove your node_modules directory from $SYNC_REPO (if exists)
Run yarn gulp commands to regenerate css files
Comment 3 Tomás Cohen Arazi (tcohen) 2022-11-16 11:32:29 UTC
Created attachment 143949 [details] [review]
Bug 32223: Remove node_modules/.bin from package.json

We should not specify the node_modules/.bin part if the env is correctly configured.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2022-11-16 11:44:52 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!