| Summary: | Add cypress and prettier to the yarn commands | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32131 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 32223 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 32224: Add cypress to yarn commands
Bug 32224: Add cypress to yarn commands Bug 32224: Add prettier to yarn commands Bug 32224: Add cypress to yarn commands Bug 32224: Add prettier to yarn commands |
||
|
Description
Jonathan Druart
2022-11-16 08:18:09 UTC
Created attachment 143943 [details] [review] Bug 32224: Add cypress to yarn commands Either I am missing something obvious, or we need to add cypress to the scripts of package.json With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I cannot run yarn run cypress run `cypress run` is working with an adjusted PATH (see https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173792905) but I think both should work. Created attachment 143969 [details] [review] Bug 32224: Add cypress to yarn commands Either I am missing something obvious, or we need to add cypress to the scripts of package.json With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I cannot run yarn run cypress run `cypress run` is working with an adjusted PATH (see https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173792905) but I think both should work. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Looks like we need prettier as well xt/vue_tidy.t is failing with: error Command "prettier" not found. Created attachment 143983 [details] [review] Bug 32224: Add prettier to yarn commands xt/vue_tidy.t was failing with: error Command "prettier" not found. Created attachment 144014 [details] [review] Bug 32224: Add cypress to yarn commands Either I am missing something obvious, or we need to add cypress to the scripts of package.json With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I cannot run yarn run cypress run `cypress run` is working with an adjusted PATH (see https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173792905) but I think both should work. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144015 [details] [review] Bug 32224: Add prettier to yarn commands xt/vue_tidy.t was failing with: error Command "prettier" not found. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! |