Summary: | Batch item modification - alignment of tick box for 'Use default values' | ||
---|---|---|---|
Product: | Koha | Reporter: | David Nind <david> |
Component: | Staff interface | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, lucas, matt.blenkinsop |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.01
|
|
Circulation function: | |||
Bug Depends on: | 30952 | ||
Bug Blocks: | |||
Attachments: |
Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification
Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification |
Description
David Nind
2022-11-16 19:13:23 UTC
Created attachment 143973 [details] [review] Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification This moves the label to the right in front of the checkbox. It also shortens the label by adding an additional longer hint text. To test: * Go to cataloguing > item batch modification * On the first page of the tool, look at the checkbox at the bottom * Apply the patch * Verify changes This solution has one disadvantage: It adds a new string. But I didn't like how squashed the label looked in either position, forced on multiple lines. Created attachment 143977 [details] [review] Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification This moves the label to the right in front of the checkbox. It also shortens the label by adding an additional longer hint text. To test: * Go to cataloguing > item batch modification * On the first page of the tool, look at the checkbox at the bottom * Apply the patch * Verify changes Signed-off-by: David Nind <david@davidnind.com> (In reply to Katrin Fischer from comment #2) > This solution has one disadvantage: It adds a new string. But I didn't like > how squashed the label looked in either position, forced on multiple lines. One more string, yes. It is a much cleaner look! Created attachment 144170 [details] [review] Bug 32236: Fix alignment of checkbox "Use default values" for item batch modification This moves the label to the right in front of the checkbox. It also shortens the label by adding an additional longer hint text. To test: * Go to cataloguing > item batch modification * On the first page of the tool, look at the checkbox at the bottom * Apply the patch * Verify changes Signed-off-by: David Nind <david@davidnind.com> Thx, Lucas! I think you forgot your sign-off line? Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x |