Summary: | Report options for adding groups/sub groups are misaligned | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Staff interface | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
Circulation function: | |||
Bug Depends on: | 30952 | ||
Bug Blocks: | |||
Attachments: |
Bug 32239: Remove uneeded CSS from reports.css
Bug 32239: Remove uneeded CSS from reports.css Bug 32239: Remove uneeded CSS from reports.css |
Description
Katrin Fischer
2022-11-17 00:21:13 UTC
It looks like this is because of some CSS in reports.css. I do not think it is needed. It looks like reports.css is used in two places: koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-report-search-result.inc:[% Asset.css("css/reports.css") | $raw %] koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt:[% Asset.css("css/reports.css") | $raw %] Created attachment 145158 [details] [review] Bug 32239: Remove uneeded CSS from reports.css To test: 1. Apply patch. 2. When adding a new SQL report, the options for adding/creating groups and sub groups should be aligned properly. 3. Turn on Mana and look at Mana Knowledge Base report search results to make sure everything is still properly aligned there. Created attachment 145169 [details] [review] Bug 32239: Remove uneeded CSS from reports.css To test: 1. Apply patch. 2. When adding a new SQL report, the options for adding/creating groups and sub groups should be aligned properly. 3. Turn on Mana and look at Mana Knowledge Base report search results to make sure everything is still properly aligned there. Signed-off-by: David Nind <david@davidnind.com> Created attachment 145823 [details] [review] Bug 32239: Remove uneeded CSS from reports.css To test: 1. Apply patch. 2. When adding a new SQL report, the options for adding/creating groups and sub groups should be aligned properly. 3. Turn on Mana and look at Mana Knowledge Base report search results to make sure everything is still properly aligned there. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Missing dependencies for 22.05.x, no backport. |