Summary: | Real time HoldsQueue does not need to check items if there are no holds | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Hold requests | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | arthur.suzuki, gmcharlt, kyle, lucas, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.01,22.05.09
|
|
Attachments: |
Bug 32247: Exit holds queue builder if there are no holds on the biblio
Bug 32247: Exit holds queue builder if there are no holds on the biblio Bug 32247: Exit holds queue builder if there are no holds on the biblio Bug 32247: Exit holds queue builder if there are no holds on the biblio |
Description
Nick Clemens (kidclamp)
2022-11-17 13:38:45 UTC
Created attachment 143999 [details] [review] Bug 32247: Exit holds queue builder if there are no holds on the biblio update_queue_for_biblio currently 1 - gets the holds on a bib 2 - gets the items available to fill any holds 3 - combines these to build the queue, exiting if there are no holds or items If there are no holds at step 1, we don't need to do step 2 or 3 This patch simply deletes the queue for this biblio, then exits if there are no holds To test: prove -v t/db_dependent/Reserves.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Hold.t t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t t/db_dependent/HoldsQueue.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Biblio_holdsqueue.t t/db_dependent/Biblio.t Created attachment 144001 [details] [review] Bug 32247: Exit holds queue builder if there are no holds on the biblio update_queue_for_biblio currently 1 - gets the holds on a bib 2 - gets the items available to fill any holds 3 - combines these to build the queue, exiting if there are no holds or items If there are no holds at step 1, we don't need to do step 2 or 3 This patch simply deletes the queue for this biblio, then exits if there are no holds To test: prove -v t/db_dependent/Reserves.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Hold.t t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t t/db_dependent/HoldsQueue.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Biblio_holdsqueue.t t/db_dependent/Biblio.t Created attachment 144040 [details] [review] Bug 32247: Exit holds queue builder if there are no holds on the biblio update_queue_for_biblio currently 1 - gets the holds on a bib 2 - gets the items available to fill any holds 3 - combines these to build the queue, exiting if there are no holds or items If there are no holds at step 1, we don't need to do step 2 or 3 This patch simply deletes the queue for this biblio, then exits if there are no holds To test: prove -v t/db_dependent/Reserves.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Hold.t t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t t/db_dependent/HoldsQueue.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Biblio_holdsqueue.t t/db_dependent/Biblio.t Signed-off-by: David <david@davidnind.com> Created attachment 144613 [details] [review] Bug 32247: Exit holds queue builder if there are no holds on the biblio update_queue_for_biblio currently 1 - gets the holds on a bib 2 - gets the items available to fill any holds 3 - combines these to build the queue, exiting if there are no holds or items If there are no holds at step 1, we don't need to do step 2 or 3 This patch simply deletes the queue for this biblio, then exits if there are no holds To test: prove -v t/db_dependent/Reserves.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Hold.t t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t t/db_dependent/Koha/BackgroundJobs/BatchDeleteBiblio.t t/db_dependent/HoldsQueue.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Biblio_holdsqueue.t t/db_dependent/Biblio.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to 22.11.x for the next release Backported to 22.05.x for upcoming 22.05.09 update_queue_for_biblio was not defined in 21.11.x. Not sure this patch is suitable for 21.11.x branch, won't backport. |