Bug 32282

Summary:	Capitalization: User id
Product:	Koha	Reporter:	Katrin Fischer <katrin.fischer>
Component:	Templates	Assignee:	Andrew Auld <andrew.auld>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	amitddng135, andrew.auld, jacob.omara, martin.renvoize
Version:	Main	Keywords:	Academy
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.01
Circulation function:
Attachments:	Bug 32282: Fixed capitalisation of ID in User ID Bug 32282: Fixed capitalisation of ID in User ID Bug 32282: Fixed capitalisation of ID in User ID

Description Katrin Fischer 2022-11-19 13:22:05 UTC

ID is an abbreviation and as such should always be capitalized:

User id => User ID

koha-tmpl/intranet-tmpl/prog/en/modules/admin/identity_providers.tt:406

Comment 1 Martin Renvoize (ashimema) 2022-11-22 14:38:21 UTC

Created attachment 144157 [details] [review]
Bug 32282: Fixed capitalisation of ID in User ID

Test plan
Step 1: go to admin>identity providers
Step 2: click 'new identity provider'
Step 3: check map point drop-down
Step 4: verify that User id is written 'User id'
Step 5: apply patch
Step 6: repeat 1-3
Step 7: verify that User ID is written 'User ID'

Comment 2 Martin Renvoize (ashimema) 2022-11-22 14:39:18 UTC

Another one submitted via github and transferred via my dev systems

Comment 3 Amit Gupta 2022-11-22 16:19:14 UTC

Created attachment 144163 [details] [review]
Bug 32282: Fixed capitalisation of ID in User ID

Test plan
Step 1: go to admin>identity providers
Step 2: click 'new identity provider'
Step 3: check map point drop-down
Step 4: verify that User id is written 'User id'
Step 5: apply patch
Step 6: repeat 1-3
Step 7: verify that User ID is written 'User ID'

Comment 4 Katrin Fischer 2022-12-04 13:06:36 UTC

Created attachment 144420 [details] [review]
Bug 32282: Fixed capitalisation of ID in User ID

Test plan
Step 1: go to admin>identity providers
Step 2: click 'new identity provider'
Step 3: check map point drop-down
Step 4: verify that User id is written 'User id'
Step 5: apply patch
Step 6: repeat 1-3
Step 7: verify that User ID is written 'User ID'

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Comment 5 Tomás Cohen Arazi (tcohen) 2022-12-07 14:39:44 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 6 Jacob O'Mara 2022-12-08 11:11:29 UTC

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.