Summary: | Capitalization: Audio Carriers, Computer Carriers ... in UNIMARC value builders | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Cath Leone <catherineleone> |
Status: | RESOLVED FIXED | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | catherineleone, david, emily.lamancusa, fridolin.somers |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the capitalization for the labels displayed in the MARC tag editor for UNIMARC subfields 181$a, 181$c, $182$a, 182$c, and 183$c, when the value builders are used. The labels are changed from capital case to sentence case, for consistency with other labels:
- Content Form -> Content form (181$a)
- Content Type -> Content type (181$c)
- Media Type Code -> Media type code (182$a)
- Media Type -> Media type (182$c)
- In the dropdown list (183$a):
. Audio Carriers -> Audio carriers
. Computer Carriers -> Computer carriers
. Microform Carriers -> Microform carriers
. Microscopic Carriers -> Microscopic carriers
. Stereographic Carriers -> Stereographic carriers
|
|
Version(s) released in: |
25.11.00,25.05.02
|
Circulation function: | |
Attachments: |
Bug 32284: Fixing capitalisation in UNIMARC value builders
Bug 32284: Fix capitalization for UNIMARC value builders Bug 32284: Fix capitalization for UNIMARC value builders |
Description
Katrin Fischer
2022-11-19 13:46:34 UTC
Same for: Computer Carriers koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:77 Content Form koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181a.tt:13 Content Type koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181c.tt:13 Media Type koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182c.tt:13 Media Type Codeā koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_182a.tt:13 Microform Carriers koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:133 Microscopic Carriers koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:195 Created attachment 184265 [details] [review] Bug 32284: Fixing capitalisation in UNIMARC value builders Test Plan: 1. In your KTD navigate to koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder 2. Run "git grep Audio Carriers" you should get results 3. Run "git grep Computer Carriers" you should get results 4. Run "git grep Content Form" you should get results 5. Run "git grep Content Type" you should get results 6. Run "git grep Media Type" you should get results 7. Run "git grep Media Type Code" you should get results 8. Run "git grep Microform Carriers" you should get results 9. Run "git grep Microscopic Carriers" you should get results 10. Apply the patch 11. Repeat steps 2-9 you should not get results Created attachment 184272 [details] [review] Bug 32284: Fix capitalization for UNIMARC value builders This patch changes the capitalization for the labels displayed in the MARC tag editor for UNIMARC subfields 181$a, 181$c, $182$a, 182$c, and 183$c, when the value builders are used. The labels are changed from capital case to sentence case, for consistency with other labels: - Content Form -> Content form (181$a) - Content Type -> Content type (181$c) - Media Type Code -> Media type code (182$a) - Media Type -> Media type (182$c) - In the dropdown list (183$a): . Audio Carriers -> Audio carriers . Computer Carriers -> Computer carriers . Microform Carriers -> Microform carriers . Microscopic Carriers -> Microscopic carriers . Stereographic Carriers -> Stereographic carriers Test plan: 1. In your KTD shell navigate to koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder 2. Run "git grep Audio Carriers" you should get results 3. Run "git grep Computer Carriers" you should get results 4. Run "git grep Content Form" you should get results 5. Run "git grep Content Type" you should get results 6. Run "git grep Media Type" you should get results 7. Run "git grep Media Type Code" you should get results 8. Run "git grep Microform Carriers" you should get results 9. Run "git grep Microscopic Carriers" you should get results 10. Apply the patch 11. Repeat steps 2-9 you should not get results Signed-off-by: David Nind <david@davidnind.com> Thanks for the patch Cath! I've updated the commit message to add a description (see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages), I've also changed the title a little bit. I've also added a draft release note. David Nind Testing notes (using koha-testing-docker): 1. To set up a UNIMARC environment, edit the KTD .env file and set MARC_FLAVOR=unimarc 2. Edit the default framework (Koha administration > Catalog > MARC bibliographic frameworks > Default framework) to add the appropriate value builders to the subfields (and remove authorized value lists if they are populated): - 181$a: add the unimarc_field_181a.pl plugin - 181$c*: remove authorized value list and add the unimarc_field_181c.pl plugin (unimarc_181c - authorized value list, already configured) - 182$a*: remove authorized value list and add the unimarc_field_182a.pl plugin (unimarc_182a - authorized value list, already configured) - 182$c*: remove authorized value list and add the unimarc_field_182c.pl plugin (unimarc_182c - authorized value list, already configured) - 183$a: add the unimarc_field_183a.pl plugin Note: the subfields with an * also have authorized value lists, which are now configured by default for the default fraemwork 3. Edit a record and add values for the subfields using the tag editor. 4. Check how the labels are displayed in the tag editor before and after the patch: - Before: Capital case - After: Sentence case 5. To check the wording (in capital case), check the UNIMARC definitions at https://www.ifla.org/unimarc-updates/unimarc-bibliographic-format-manual-online-ed/ (pages 262-272 of the PDF). 6. Changes: - Content Form -> Content form (181$a) - Content Type -> Content type (181$c) - Media Type Code -> Media type code (182$a) - Media Type -> Media type (182$c) - In a dropdown list (183$a): . Audio Carriers -> Audio carriers . Computer Carriers -> Computer carriers . Microform Carriers -> Microform carriers . Microscopic Carriers -> Microscopic carriers . Stereographic Carriers -> Stereographic carriers Created attachment 184392 [details] [review] Bug 32284: Fix capitalization for UNIMARC value builders This patch changes the capitalization for the labels displayed in the MARC tag editor for UNIMARC subfields 181$a, 181$c, $182$a, 182$c, and 183$c, when the value builders are used. The labels are changed from capital case to sentence case, for consistency with other labels: - Content Form -> Content form (181$a) - Content Type -> Content type (181$c) - Media Type Code -> Media type code (182$a) - Media Type -> Media type (182$c) - In the dropdown list (183$a): . Audio Carriers -> Audio carriers . Computer Carriers -> Computer carriers . Microform Carriers -> Microform carriers . Microscopic Carriers -> Microscopic carriers . Stereographic Carriers -> Stereographic carriers Test plan: 1. In your KTD shell navigate to koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder 2. Run "git grep Audio Carriers" you should get results 3. Run "git grep Computer Carriers" you should get results 4. Run "git grep Content Form" you should get results 5. Run "git grep Content Type" you should get results 6. Run "git grep Media Type" you should get results 7. Run "git grep Media Type Code" you should get results 8. Run "git grep Microform Carriers" you should get results 9. Run "git grep Microscopic Carriers" you should get results 10. Apply the patch 11. Repeat steps 2-9 you should not get results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Looks great! Thanks, Cath! Passing QA Nice work everyone! Pushed to main for 25.11 Nice work everyone! Pushed to 25.05.x I prefer not backport to 24.11 to avoid translation work No update to the manual required. |