| Summary: | "library category" messages should be removed (not used) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | arthur.suzuki, dcook, gmcharlt, jonathan.druart, lucas, matt.blenkinsop, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00, 22.11.01, 22.05.09, 21.11.16
|
|
| Circulation function: | |||
| Bug Depends on: | 16735 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt
Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt |
||
This is coming from bug 16735 that forgot to remove those messages. Created attachment 144191 [details] [review] Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt On bug 16735 we rewrite the library groups system. Those references in branches.tt were part of the previous code, and they can be removed. Test plan: Confirm the above and that those code errors are never sent to the template. Created attachment 144399 [details] [review] Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt On bug 16735 we rewrite the library groups system. Those references in branches.tt were part of the previous code, and they can be removed. Test plan: Confirm the above and that those code errors are never sent to the template. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 144425 [details] [review] Bug 32291: (bug 16735 follow-up) Remove ref to library category in branches.tt On bug 16735 we rewrite the library groups system. Those references in branches.tt were part of the previous code, and they can be removed. Test plan: Confirm the above and that those code errors are never sent to the template. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Nice work everyone! Pushed to stable for 22.11.x Backported to 22.05.x for upcoming 22.05.09 applied to 21.11.x for 21.11.16 Not backported to 21.05.x |
Also noticed a while ago, while translating. The errors mention library categories repeatedly, but I didn't figure out how to trigger those messages or what they were referring to. What is a library category and how can you add one? The page is Administration > Libraries koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt [% CASE 'error_on_update_category' %] <span>An error occurred when updating this library category. Perhaps it already exists.</span> [% CASE 'error_on_insert_category' %] <span>An error occurred when adding this library category. The categorycode might already exist.</span> [% CASE 'error_on_delete_category' %] <span>An error occurred when deleting this library category. Check the logs.</span> [% CASE 'success_on_update_category' %] <span>Library category updated successfully.</span> [% CASE 'success_on_insert_category' %] <span>Library category added successfully.</span> [% CASE 'success_on_delete_category' %] <span>Library category deleted successfully.</span> [% CASE 'cannot_delete_category' %] <span>This library category cannot be deleted. [% m.data.libraries_count | html %] libraries are still using it.</span>