| Summary: | Terminology: Some budgets are not defined in item records | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | david, lucas |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04
|
|
| Circulation function: | |||
| Bug Depends on: | 32888 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 32293: Fix terminology in warning when creating orders from staged file
Bug 32293: Fix terminology in warning when creating orders from staged file Bug 32293: Fix terminology in warning when creating orders from staged file |
||
Created attachment 146188 [details] [review] Bug 32293: Fix terminology in warning when creating orders from staged file When you are ordering from a staged file and the fund is missing, there is a warning: Some budgets are not defined in item records Budgets shoudl be funds here. To test: * Add a new basket * Add an order from a staged file or from a file * Leave the fund values of some selected items empty * Make sure default fund entry is also empty * Warning message should be triggered on saving * Apply patch, repeat, verify it is correct now. There is currently an issue in bug 32888 that means we can no longer trigger that warning/message as it just uses the first fund found. Created attachment 146358 [details] [review] Bug 32293: Fix terminology in warning when creating orders from staged file When you are ordering from a staged file and the fund is missing, there is a warning: Some budgets are not defined in item records Budgets shoudl be funds here. To test: * Add a new basket * Add an order from a staged file or from a file * Leave the fund values of some selected items empty * Make sure default fund entry is also empty * Warning message should be triggered on saving * Apply patch, repeat, verify it is correct now. Signed-off-by: David Nind <david@davidnind.com> As the warning can't be triggered until there is a patch for bug 32888, I tested by reviewing the diff. Created attachment 147240 [details] [review] Bug 32293: Fix terminology in warning when creating orders from staged file When you are ordering from a staged file and the fund is missing, there is a warning: Some budgets are not defined in item records Budgets shoudl be funds here. To test: * Add a new basket * Add an order from a staged file or from a file * Leave the fund values of some selected items empty * Make sure default fund entry is also empty * Warning message should be triggered on saving * Apply patch, repeat, verify it is correct now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Missing dependencies for 22.05.x, no backport |
The error message should use 'funds' not 'budgets': koha-tmpl/intranet-tmpl/prog/js/addorderiso2709.js: alert( __("Some budgets are not defined in item records") ) I think that this one appears when you try to add orders from a staged file, but leave the fund empty.