Bug 32296

Summary: Capitalization: Specification of Dimensionality,...
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: Toni Gardiner <tonig>
Status: Needs documenting --- QA Contact: Emily Lamancusa (emlam) <emily.lamancusa>
Severity: trivial    
Priority: P5 - low CC: david, dcook, emily.lamancusa, fridolin.somers, tonig
Version: MainKeywords: Academy
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes the capitalization for the labels displayed in the MARC tag editor for UNIMARC 181$b, when the value builder unimarc_field_181b.pl is used. The labels are changed from capital case to sentence case, for consistency with other labels: - Specification of type (position 0) - Specification of motion (position 1) - Specification of dimensionality (position 2) - Sensory specification 1, 2 and 3 (positions 3 to 5)
Version(s) released in:
25.11.00,25.05.02
Circulation function:
Attachments: Bug 32296: Capitalization: Specification of Dimensionality
Bug 32296: Capitalization - UNIMARC labels for 181$b value builder
Bug 32296: Capitalization - UNIMARC labels for 181$b value builder

Description Katrin Fischer 2022-11-20 01:42:04 UTC
Specification of Dimensionality␠
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181b.tt:79

Specification of Motion␠
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181b.tt:49

Specification of Type
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_181b.tt:13

Stereographic Carriers
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_183a.tt:271
Comment 1 Toni Gardiner 2025-07-17 23:41:54 UTC
Created attachment 184259 [details] [review]
Bug 32296: Capitalization: Specification of Dimensionality

Test plan: check capitalisation in patch
Comment 2 David Nind 2025-07-18 02:41:58 UTC
Created attachment 184271 [details] [review]
Bug 32296: Capitalization - UNIMARC labels for 181$b value builder

This patch changes the capitalisation for the labels displayed in
the MARC editor for UNIMARC 181$b, when the value builder
unimarc_field_181b.pl is used. The labels are changed from capital
case to sentence case, to be consistent with other labels:
- Specification of type (position 0)
- Specification of motion (position 1)
- Specification of dimensionality (position 2)
- Sensory specification 1, 2 and 3 (positions 3 to 5)

Test plan:
1. Check the capitalisation in the patch.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2025-07-18 02:49:27 UTC
Thanks for the patch Toni!

I've updated the commit message to add a description (see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages), I've also changed the title a little bit.

I've also added a draft release note.

David Nind

Testing notes (using koha-testing-docker):
1. To set up a UNIMARC environment, edit the KTD .env file and set MARC_FLAVOR=unimarc
2. Edit the default framework (Koha administration > Catalog > MARC bibliographic frameworks > Dedfault framework) for 181$b to add unimarc_field_181b.pl as the plugin.
3. Edit a record and add values for 181$b using the tag editor.
4. Check how the labels are displayed in the tag editor before and after the patch:
   - Before: Capital case
   - After: Sentence case
5. To check the wording (in capital case), check the UNIMARC definitions at https://www.ifla.org/unimarc-updates/unimarc-bibliographic-format-manual-online-ed/ (pages 262-263 of the PDF).
Comment 4 Emily Lamancusa (emlam) 2025-07-18 14:37:03 UTC
Created attachment 184391 [details] [review]
Bug 32296: Capitalization - UNIMARC labels for 181$b value builder

This patch changes the capitalisation for the labels displayed in
the MARC editor for UNIMARC 181$b, when the value builder
unimarc_field_181b.pl is used. The labels are changed from capital
case to sentence case, to be consistent with other labels:
- Specification of type (position 0)
- Specification of motion (position 1)
- Specification of dimensionality (position 2)
- Sensory specification 1, 2 and 3 (positions 3 to 5)

Test plan:
1. Check the capitalisation in the patch.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 5 Emily Lamancusa (emlam) 2025-07-18 14:37:36 UTC
Looks great! Thanks, Toni! Passing QA
Comment 6 Lucas Gass (lukeg) 2025-07-21 20:03:11 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 7 Paul Derscheid 2025-07-24 19:03:42 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 8 Fridolin Somers 2025-08-01 13:51:38 UTC
I prefer not backport to 24.11 to avoid translation work