Bug 32322

Summary:	Column settings menu should not include "select all \|none" in label text for Check In column
Product:	Koha	Reporter:	Andrew Fuerste-Henry <andrew>
Component:	Circulation	Assignee:	Jacob O'Mara <jacob.omara>
Status:	Failed QA ---	QA Contact:	Testopia <testopia>
Severity:	normal
Priority:	P5 - low	CC:	david, fridolin.somers, gmcharlt, jacob.omara, kyle.m.hall
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 32322 : Removal of "Select all\|None"

Description Andrew Fuerste-Henry 2022-11-22 15:41:11 UTC

On both the Checkout (circulation, issues-table) and Details (moremember, issues-table) tab of the patron record, the table of checkouts data includes a column to select items to check in. On both tables, the label to toggle this column on and off with the Columns button is labled "Check in select all | none." We don't need the "select all | none" part. It should just say "Check in."

Comment 1 Jacob O'Mara 2022-11-23 16:32:10 UTC

Created attachment 144209 [details] [review]
Bug 32322 : Removal of "Select all|None"

Removed "Select all|None" from check in column of circ > checkouts and circ > details pages

Test Plan:

Navigate to Circulation > checkouts > *user*
Ensure *user* has book checked out
Observe that under both the Check Out and Details tabs on the left, the table has a column labelled "Check in select all | none."
Apply Patch
Observe that the above column on both tabs now reads "Check in"

Comment 2 Andrew Fuerste-Henry 2022-11-23 17:40:43 UTC

Sorry, I wasn't quite clear. I think it's helpful to have "select all | none" in the column header itself. I don't think we need to include it in the Column Settings menu that pops up when you click the Columns button. Your patch removes the wording in both places.

Comment 3 Katrin Fischer 2022-11-23 21:46:53 UTC

While I agree that it's confusing to see this in the column settings, I don't think it can be removed from one but not the other place. What you see in the "columns" list is build with JS from the table headings 1:1.

Maybe the select all | none could be moved somewhere else? Or wrapped into a classs that is then hidden from the column listing?

Comment 4 David Nind 2022-11-24 18:23:19 UTC

Changed assignee.

Comment 5 Fridolin Somers 2022-12-22 06:28:13 UTC

Heuuu this patch simply removes the checkboxes select feature.
It is a regression.

(In reply to Katrin Fischer from comment #3)
> Maybe the select all | none could be moved somewhere else? Or wrapped into a
> classs that is then hidden from the column listing?
Good idea.
Looks like the column name comes from th aria-label attribute, that contains the text-only version of th content.