Bug 32351

Summary: Fix all TestBuilder calls failing due to wrong column names
Product: Koha Reporter: Marcel de Rooy <m.de.rooy>
Component: Test SuiteAssignee: Tomás Cohen Arazi <tomascohen>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: jacob.omara, jonathan.druart, martin.renvoize, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00, 22.11.01
Bug Depends on: 32350    
Bug Blocks:    
Attachments: Bug 32351: Holds.t - replace biblionumber by biblio_id
Bug 32351: Holds.t - remove wrong column reference
Bug 32351: Fix Acquisition.t
Bug 32351: Fix Budgets.t
Bug 32351: Fix Illrequests.t
Bug 32351: Fix Members.t
Bug 32351: Fix Reserves.t
Bug 32351: Fix Circulation.t
Bug 32351: Holds.t - remove wrong column reference
Bug 32351: Fix Acquisition.t
Bug 32351: Fix Budgets.t
Bug 32351: Fix Illrequests.t
Bug 32351: Fix Members.t
Bug 32351: Fix Reserves.t
Bug 32351: Fix Circulation.t
Bug 32351: Fix CourseItems.t
Bug 32351: Fix TemplateToolkit.t
Bug 32351: Fix Koha/Patrons.t
Bug 32351: Fix t/db_dependent/api/v1/patrons.t
Bug 32351: Fix t/db_dependent/Circulation/NoIssuesChargeGuarantees.t
Bug 32351: Fix t/db_dependent/Koha/Charges/Sales.t

Description Marcel de Rooy 2022-11-25 10:46:27 UTC
See 32350. Follow-up.
Comment 1 Marcel de Rooy 2022-11-25 10:51:36 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2022-11-25 11:10:40 UTC
Created attachment 144240 [details] [review]
Bug 32351: Holds.t - remove wrong column reference

Found by bug 32350.
The test does not need this value at all..

Test plan:
Run test.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Jonathan Druart 2022-11-25 11:36:11 UTC
Created attachment 144243 [details] [review]
Bug 32351: Fix Acquisition.t
Comment 4 Jonathan Druart 2022-11-25 11:43:31 UTC
Created attachment 144244 [details] [review]
Bug 32351: Fix Budgets.t
Comment 5 Jonathan Druart 2022-11-25 11:46:00 UTC
Created attachment 144249 [details] [review]
Bug 32351: Fix Illrequests.t
Comment 6 Jonathan Druart 2022-11-25 11:48:01 UTC
Created attachment 144250 [details] [review]
Bug 32351: Fix Members.t
Comment 7 Jonathan Druart 2022-11-25 11:49:25 UTC
Created attachment 144251 [details] [review]
Bug 32351: Fix Reserves.t

itemtypes.notforloan already defaults to 0
Comment 8 Jonathan Druart 2022-11-25 11:57:30 UTC
Created attachment 144252 [details] [review]
Bug 32351: Fix Circulation.t
Comment 9 Martin Renvoize 2022-11-30 14:58:55 UTC
Should this be NSO rather than Assigned?
Comment 10 Tomás Cohen Arazi 2022-11-30 15:27:00 UTC
Let's leave it ASSIGNED and we just keep adding patches here.
Comment 11 Tomás Cohen Arazi 2022-11-30 18:56:19 UTC
Created attachment 144353 [details] [review]
Bug 32351: Holds.t - remove wrong column reference

Found by bug 32350.
The test does not need this value at all..

Test plan:
Run test.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 12 Tomás Cohen Arazi 2022-11-30 18:56:32 UTC
Created attachment 144354 [details] [review]
Bug 32351: Fix Acquisition.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 13 Tomás Cohen Arazi 2022-11-30 18:56:50 UTC
Created attachment 144355 [details] [review]
Bug 32351: Fix Budgets.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 14 Tomás Cohen Arazi 2022-11-30 18:57:09 UTC
Created attachment 144356 [details] [review]
Bug 32351: Fix Illrequests.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 15 Tomás Cohen Arazi 2022-11-30 18:57:27 UTC
Created attachment 144357 [details] [review]
Bug 32351: Fix Members.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 16 Tomás Cohen Arazi 2022-11-30 18:57:44 UTC
Created attachment 144358 [details] [review]
Bug 32351: Fix Reserves.t

itemtypes.notforloan already defaults to 0

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 17 Tomás Cohen Arazi 2022-11-30 18:57:54 UTC
Created attachment 144359 [details] [review]
Bug 32351: Fix Circulation.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 18 Tomás Cohen Arazi 2022-11-30 18:58:01 UTC
Created attachment 144360 [details] [review]
Bug 32351: Fix CourseItems.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 19 Tomás Cohen Arazi 2022-11-30 18:58:10 UTC
Created attachment 144361 [details] [review]
Bug 32351: Fix TemplateToolkit.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 20 Tomás Cohen Arazi 2022-11-30 18:58:19 UTC
Created attachment 144362 [details] [review]
Bug 32351: Fix Koha/Patrons.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 21 Tomás Cohen Arazi 2022-11-30 18:58:30 UTC
Created attachment 144363 [details] [review]
Bug 32351: Fix t/db_dependent/api/v1/patrons.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 22 Tomás Cohen Arazi 2022-11-30 18:58:42 UTC
Created attachment 144364 [details] [review]
Bug 32351: Fix  t/db_dependent/Circulation/NoIssuesChargeGuarantees.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 23 Tomás Cohen Arazi 2022-11-30 18:58:55 UTC
Created attachment 144365 [details] [review]
Bug 32351: Fix t/db_dependent/Koha/Charges/Sales.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 24 Tomás Cohen Arazi 2022-11-30 18:59:40 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 25 Marcel de Rooy 2022-12-01 07:11:05 UTC
(In reply to Tomás Cohen Arazi from comment #24)
> Pushed to master for 22.11.
> 
> Nice work everyone, thanks!

Thx Tomas for your acceleration here :)
Comment 26 Martin Renvoize 2022-12-01 07:39:26 UTC
Awesome work here, thanks :)
Comment 27 Jonathan Druart 2022-12-01 08:23:09 UTC
Thanks, Tomas!
Comment 28 Jacob O'Mara 2022-12-02 10:57:53 UTC
Nice work! Pushed to 22.11.x