|
Description
Marcel de Rooy
2022-11-25 10:46:27 UTC
Created attachment 144236 [details] [review] Bug 32351: Holds.t - replace biblionumber by biblio_id Trivial fix, found by bug 32350. Note that the test also passes without this value hash ;) Test plan: Run test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 144240 [details] [review] Bug 32351: Holds.t - remove wrong column reference Found by bug 32350. The test does not need this value at all.. Test plan: Run test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 144243 [details] [review] Bug 32351: Fix Acquisition.t Created attachment 144244 [details] [review] Bug 32351: Fix Budgets.t Created attachment 144249 [details] [review] Bug 32351: Fix Illrequests.t Created attachment 144250 [details] [review] Bug 32351: Fix Members.t Created attachment 144251 [details] [review] Bug 32351: Fix Reserves.t itemtypes.notforloan already defaults to 0 Created attachment 144252 [details] [review] Bug 32351: Fix Circulation.t Should this be NSO rather than Assigned? Let's leave it ASSIGNED and we just keep adding patches here. Created attachment 144353 [details] [review] Bug 32351: Holds.t - remove wrong column reference Found by bug 32350. The test does not need this value at all.. Test plan: Run test. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144354 [details] [review] Bug 32351: Fix Acquisition.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144355 [details] [review] Bug 32351: Fix Budgets.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144356 [details] [review] Bug 32351: Fix Illrequests.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144357 [details] [review] Bug 32351: Fix Members.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144358 [details] [review] Bug 32351: Fix Reserves.t itemtypes.notforloan already defaults to 0 Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144359 [details] [review] Bug 32351: Fix Circulation.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144360 [details] [review] Bug 32351: Fix CourseItems.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144361 [details] [review] Bug 32351: Fix TemplateToolkit.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144362 [details] [review] Bug 32351: Fix Koha/Patrons.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144363 [details] [review] Bug 32351: Fix t/db_dependent/api/v1/patrons.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144364 [details] [review] Bug 32351: Fix t/db_dependent/Circulation/NoIssuesChargeGuarantees.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 144365 [details] [review] Bug 32351: Fix t/db_dependent/Koha/Charges/Sales.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! (In reply to Tomás Cohen Arazi from comment #24) > Pushed to master for 22.11. > > Nice work everyone, thanks! Thx Tomas for your acceleration here :) Awesome work here, thanks :) Thanks, Tomas! Nice work! Pushed to 22.11.x |