Bug 32355

Summary: Add class url to all URL syspref
Product: Koha Reporter: Didier Gautheron <didier.gautheron>
Component: Staff interfaceAssignee: Didier Gautheron <didier.gautheron>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: arthur.suzuki, david, gmcharlt, lucas, wainuiwitikapark
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.01, 22.05.09, 21.11.16
Circulation function:
Attachments: Bug 32355: Add css class url to URL syspref
Bug 32355: Add css class url to URL syspref
Bug 32355: Add css class url to URL syspref

Description Didier Gautheron 2022-11-28 07:28:35 UTC
Hi,

Some syspref aren't defined as class url and their input field is too small.

To Test:
1 - open admin/preferences.pl
2 - Search for URL
3 - casServerUrl, UsageStatsLibraryUrl, KohaManualBaseURL,
    PrivacyPolicyURL, LibrisURL input field size are small.
4 - Apply patch
5 - all URL fields have the same bigger size.
Comment 1 Didier Gautheron 2022-11-28 07:33:21 UTC
Created attachment 144275 [details] [review]
Bug 32355: Add css class url to URL syspref

Add missing css class to URL syspref.

To Test:
1 - open admin/preferences.pl
2 - Search for URL
3 - casServerUrl, UsageStatsLibraryUrl, KohaManualBaseURL,
    PrivacyPolicyURL, LibrisURL input field size are small.
4 - Apply patch
5 - all URL fields have the same bigger size.
Comment 2 David Nind 2022-11-28 11:29:35 UTC
Created attachment 144280 [details] [review]
Bug 32355: Add css class url to URL syspref

Add missing css class to URL syspref.

To Test:
1 - open admin/preferences.pl
2 - Search for URL
3 - casServerUrl, UsageStatsLibraryUrl, KohaManualBaseURL,
    PrivacyPolicyURL, LibrisURL input field size are small.
4 - Apply patch
5 - all URL fields have the same bigger size.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2022-11-28 11:30:53 UTC
Changed assignee.
Comment 4 Katrin Fischer 2022-12-07 21:22:20 UTC
Created attachment 144491 [details] [review]
Bug 32355: Add css class url to URL syspref

Add missing css class to URL syspref.

To Test:
1 - open admin/preferences.pl
2 - Search for URL
3 - casServerUrl, UsageStatsLibraryUrl, KohaManualBaseURL,
    PrivacyPolicyURL, LibrisURL input field size are small.
4 - Apply patch
5 - all URL fields have the same bigger size.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi (tcohen) 2022-12-13 12:27:39 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Martin Renvoize (ashimema) 2022-12-15 13:30:49 UTC
Nice work everyone!

Pushed to 22.11.x for the next release
Comment 7 Lucas Gass (lukeg) 2023-01-19 22:43:06 UTC
Backported to 22.05.x for upcoming 22.05.09
Comment 8 Arthur Suzuki 2023-01-26 10:12:24 UTC
applied to 21.11.x for 21.11.16 (backported from 22.05.x)
Comment 9 Wainui Witika-Park 2023-03-15 01:30:17 UTC
Not backported to 21.05.x