Bug 32366

Summary:	BatchDeleteBiblio task should have tests to prove indexing all takes place in one step
Product:	Koha	Reporter:	Martin Renvoize (ashimema) <martin.renvoize>
Component:	Test Suite	Assignee:	Jonathan Druart <jonathan.druart>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	jacob.omara, jonathan.druart
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.01
Circulation function:
Bug Depends on:	30460
Bug Blocks:
Attachments:	Bug 32366: (bug 30460 follow-up) Add tests Bug 32366: (bug 30460 follow-up) Add tests

Description Martin Renvoize (ashimema) 2022-11-29 14:50:13 UTC

We worked through changing our code such that we actioned the batch deletes in a loop passing skip_record_index and then finally passed a list of biblios to specialUpdate all in one hit at the end..

But we forgot to add unit tests for this change!

Comment 1 Jonathan Druart 2022-11-30 07:57:45 UTC

Created attachment 144339 [details] [review]
Bug 32366: (bug 30460 follow-up) Add tests

Comment 2 Martin Renvoize (ashimema) 2022-11-30 12:55:50 UTC

Created attachment 144346 [details] [review]
Bug 32366: (bug 30460 follow-up) Add tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 3 Martin Renvoize (ashimema) 2022-11-30 12:57:07 UTC

Oh, thanks for jumping on this Jonathan, you beat me to it.

It's a nice trivial test once you wrap you head around it.. so going straight for a PQA.

Comment 4 Tomás Cohen Arazi (tcohen) 2022-12-01 13:04:50 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 5 Jacob O'Mara 2022-12-05 12:21:33 UTC

Nice work, thanks everyone!

Pushed to 22.11.x for the next release.