Bug 32460

Summary: Columns missing from table configuration for patron categories
Product: Koha Reporter: Sara Brown <sbrown>
Component: Architecture, internals, and plumbingAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: trivial    
Priority: P5 - low CC: arthur.suzuki, jacob.omara, Laura.escamilla, lucas, martin.renvoize
Version: 22.05   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04,22.05.11
Circulation function:
Attachments: Bug 32460: Add missing columns to table configuration for patron categories
Bug 32460: Add missing columns to table configuration for patron categories

Description Sara Brown 2022-12-13 17:40:21 UTC
The 'categories' table in Administration-Table settings doesn't have a 'password expiration' option, and it appears to be causing column selection for the table to be shifted by one starting with 'age required'. When I select to hide 'age required', 'Password expired' is the column that's actually hidden. All columns after that appear to follow by being off by one.
Comment 1 Sara Brown 2022-12-13 17:42:31 UTC
Correction: it's the 'categories' page, but the table ID is 'patron_categories'
Comment 2 Katrin Fischer 2022-12-28 21:37:06 UTC
Created attachment 144881 [details] [review]
Bug 32460: Add missing columns to table configuration for patron categories

The table settings were missing the recently added columns, resulting
in strange behaviour using the column visibility settings:

* patron expiration
* can be guarantee
* exclude from local holds priority

To test:
* Go to administration > patron categories
* Verify some columns are missing from the Columns selection
* Apply patch
* Verify the missing columns are now present and all columns
  can be hidden/unhidden as expected
* Change settings for the table in administration > table settings
* Verify the settings have the desired effect
Comment 3 Laura Escamilla 2022-12-29 18:48:39 UTC
The columns below are all now visible and working appropriately in the Patron Categories table:
*password expiration - (I think this is what you meant instead of patron expiration)
*can be guarantee
*exclude from local holds priority

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Comment 4 Martin Renvoize (ashimema) 2023-01-31 13:16:25 UTC
Created attachment 145866 [details] [review]
Bug 32460: Add missing columns to table configuration for patron categories

The table settings were missing the recently added columns, resulting
in strange behaviour using the column visibility settings:

* patron expiration
* can be guarantee
* exclude from local holds priority

To test:
* Go to administration > patron categories
* Verify some columns are missing from the Columns selection
* Apply patch
* Verify the missing columns are now present and all columns
  can be hidden/unhidden as expected
* Change settings for the table in administration > table settings
* Verify the settings have the desired effect

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2023-01-31 13:16:54 UTC
No regressions, Passing QA
Comment 6 Tomás Cohen Arazi (tcohen) 2023-02-22 12:08:10 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Jacob O'Mara 2023-02-24 11:32:57 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 8 Jacob O'Mara 2023-02-24 11:36:09 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 9 Lucas Gass (lukeg) 2023-03-01 15:01:55 UTC
Backported to 22.05.x for upcoming 22.05.11
Comment 10 Arthur Suzuki 2023-03-29 10:24:23 UTC
I don't reproduce this bug in 21.11, the mentioned columns seems not to be present in the database.
won't apply unless needed.