|
Description
Mathieu Saby
2022-12-19 09:23:27 UTC
Created attachment 181505 [details] [review] Bug 32488: Add RDA content, media, and carrier fields to ES mappings MARC21 I didn't add the UNIMARC mappings, they seem to be much more specifically coded, so I am not sure if they can go into the same fields. Possibly we want a bug for each MARC flavour? I can take care of a followup for Unimarc in an other bug ;-) But you added it only for Elasticsearch. Should we not also add it for Zebra ? (In reply to Mathieu Saby from comment #4) > But you added it only for Elasticsearch. Should we not also add it for Zebra > ? +1 I think so too Created attachment 182034 [details] [review] Bug 32488: Zebra updates and aliases (In reply to David Cook from comment #5) > (In reply to Mathieu Saby from comment #4) > > But you added it only for Elasticsearch. Should we not also add it for Zebra > > ? > > +1 I think so too Added, but I can't make them work, tossing them here for other eyes, been a while since I touched zebra This looks ok, I think. Have you: 1) Copied the files into the right place in ktd? Something like this I believe: sudo cp -i etc/zebradb/biblios/etc/bib1.att /etc/koha/zebradb/biblios/etc/bib1.att sudo cp -i etc/zebradb/ccl.properties /etc/koha/zebradb/ccl.properties sudo cp -i etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 2) Restarted Zebra? I've tested the Elasticsearch changes, and these work, so happy to sign off. Not sure how to test the Zebra changes. Elasticsearch testing notes (using KTD): 1. Start up KTD with ES7: ktd --es7 up 2. Go to Koha administration > Catalog > Search engine configuration (Elasticsearch) > Bibliohgraphic records 3. Search the page for 336, 337, and 338 4. Note that there are no search field mappings for this tag 5. Apply the patch 6. Either reset everything (reset_all) or from the staff interface (Reset mappings) 7. Note that these new mappings are in place: . content-type-code: 336b . content-type-term: 336a . media-type-code: 337b . media-type-term: 337a . carrier-type-code: 338b . carrier-type-term: 338a Created attachment 191400 [details] [review] Bug 32488: Add RDA content, media, and carrier fields to ES mappings MARC21 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 191401 [details] [review] Bug 32488: Zebra updates and aliases Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 191402 [details] [review] Bug 32488: (follow-up) Zebra: Fix mapping of ports to indexes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> 1) QA checks - pass. 2) Code review - nothing found 3) Testing a) Zebra sudo cp -i etc/zebradb/biblios/etc/bib1.att /etc/koha/zebradb/biblios/etc/bib1.att sudo cp -i etc/zebradb/ccl.properties /etc/koha/zebradb/ccl.properties sudo cp -i etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl sudo koha-zebra --restart kohadev Edit record, add fields, save This gave me some headache since my searches still wouldn't work. The issue is here: +Media-type-term 1=9020 +mett Media-type-term +Media-type-code 1=9021 +metc Media-type-code +att 9020 Media-type-code +att 9021 Media-type-term Ports have been switched. Fixed in a follow-up. b) Elasticsearch Worked nicely. 4) Notes UNIMARC mappings are still missing. I have filed a new bug report: bug 41610 |