| Summary: | In Elasticsearch mappings table use search field name | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Searching - Elasticsearch | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | arthur.suzuki, lucas, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31887 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.04,22.05.12,21.11.20
|
|
| Circulation function: | |||
| Attachments: |
Bug 32519: In Elasticsearch mappings table use of search field name and label
Bug 32519: In Elasticsearch mappings table use of search field name and label Bug 32519: In Elasticsearch mappings table use of search field name and label |
||
|
Description
Fridolin Somers
2022-12-23 05:55:29 UTC
Also the lines are sorting alphabetically by search field name. So I propose to display name and label between parenthesis. And also add label to the form in last line. By default label equals name so I display label only if different from name. Created attachment 144811 [details] [review] Bug 32519: In Elasticsearch mappings table use of search field name and label In Elasticsearch mappings table, in tabs for mappings we should add search field name in addition to label ; in order to find them when searching using DataTable search field. This is very useful when debugging. Also the lines are sorting alphabetically by search field name. So I propose to display name and label between parenthesis. And also add label to the form in last line. By default label equals name so I display label only if different from name. Test plan : 1) Go to : Administration > Search engine configuration (Elasticsearch) 2) In first tabe edit a line to change label, for example : author => Auteur 3) Save 4) Go to second tab 5) Check you see a line with 'author (Auteur)' and lines with only name when label equals name 6) Look at last line (addition form) 7) Check you see in combobox : 'author (Auteur)' and lines with only name when label equals name Created attachment 145248 [details] [review] Bug 32519: In Elasticsearch mappings table use of search field name and label In Elasticsearch mappings table, in tabs for mappings we should add search field name in addition to label ; in order to find them when searching using DataTable search field. This is very useful when debugging. Also the lines are sorting alphabetically by search field name. So I propose to display name and label between parenthesis. And also add label to the form in last line. By default label equals name so I display label only if different from name. Test plan : 1) Go to : Administration > Search engine configuration (Elasticsearch) 2) In first tabe edit a line to change label, for example : author => Auteur 3) Save 4) Go to second tab 5) Check you see a line with 'author (Auteur)' and lines with only name when label equals name 6) Look at last line (addition form) 7) Check you see in combobox : 'author (Auteur)' and lines with only name when label equals name Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Created attachment 147250 [details] [review] Bug 32519: In Elasticsearch mappings table use of search field name and label In Elasticsearch mappings table, in tabs for mappings we should add search field name in addition to label ; in order to find them when searching using DataTable search field. This is very useful when debugging. Also the lines are sorting alphabetically by search field name. So I propose to display name and label between parenthesis. And also add label to the form in last line. By default label equals name so I display label only if different from name. Test plan : 1) Go to : Administration > Search engine configuration (Elasticsearch) 2) In first tabe edit a line to change label, for example : author => Auteur 3) Save 4) Go to second tab 5) Check you see a line with 'author (Auteur)' and lines with only name when label equals name 6) Look at last line (addition form) 7) Check you see in combobox : 'author (Auteur)' and lines with only name when label equals name Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 23.05. Nice work everyone, thanks! Nice work everyone! Pushed to stable for 22.11.x Backported to 22.05.x for upcoming 22.05.12 applied to 21.11.x for 21.11.20 Not backported to 21.05.x |