Summary: | borrowers.flags should not be an option in any BorrowerMandatory or BorrowerUnwanted system preferences | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | System Administration | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
Circulation function: | |||
Bug Depends on: | 32535 | ||
Bug Blocks: | |||
Attachments: |
Bug 32544: Remove flags as option from several patron form related system preferences
Bug 32544: Remove flags as option from several patron form related system preferences Bug 32544: Remove flags as option from several patron form related system preferences |
Description
Andrew Fuerste-Henry
2022-12-28 20:56:51 UTC
Created attachment 144877 [details] [review] Bug 32544: Remove flags as option from several patron form related system preferences Because permissions aren't actually set via the patron edit screens, these checkboxes have no real purpose or effect. This removes flags from the selectable fields of the following system preferences: * PatronSelfModificationMandatoryField * PatronSelfRegistrationBorrowerMandatoryField * BorrowerMandatoryField * PatronSelfModificationBorrowerUnwantedField * PatronSelfRegistrationBorrowerUnwantedField To test: * Apply patch * Verify that the checkbox for flags can no longer be set for these preferences Created attachment 144880 [details] [review] Bug 32544: Remove flags as option from several patron form related system preferences Because permissions aren't actually set via the patron edit screens, these checkboxes have no real purpose or effect. This removes flags from the selectable fields of the following system preferences: * PatronSelfModificationMandatoryField * PatronSelfRegistrationBorrowerMandatoryField * BorrowerMandatoryField * PatronSelfModificationBorrowerUnwantedField * PatronSelfRegistrationBorrowerUnwantedField To test: * Apply patch * Verify that the checkbox for flags can no longer be set for these preferences Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Created attachment 145852 [details] [review] Bug 32544: Remove flags as option from several patron form related system preferences Because permissions aren't actually set via the patron edit screens, these checkboxes have no real purpose or effect. This removes flags from the selectable fields of the following system preferences: * PatronSelfModificationMandatoryField * PatronSelfRegistrationBorrowerMandatoryField * BorrowerMandatoryField * PatronSelfModificationBorrowerUnwantedField * PatronSelfRegistrationBorrowerUnwantedField To test: * Apply patch * Verify that the checkbox for flags can no longer be set for these preferences Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Another nice fix, no regressions.. Passing QA. Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |