| Summary: | Reindent items with no checkouts reports template | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 32587 | ||
| Attachments: |
Bug 32586: Reindent items with no checkouts report template
Bug 32586: Reindent items with no checkouts report template Bug 32586: Reindent items with no checkouts report template |
||
|
Description
Katrin Fischer
2023-01-07 00:05:07 UTC
Created attachment 145121 [details] [review] Bug 32586: Reindent items with no checkouts report template The indentation in the template was off and also full of tab characters, so this does some clean-up prior to doing some other small changes on separate bugs. To test: * Run the 'Items with no checkouts' report in the report module * Note: If you get an error in this step, you need to turn of sql_strict_mode in your koha-conf.xml, but this bug is out of scope here. * Apply patch * Rerun the report, it should appear unchanged Created attachment 145125 [details] [review] Bug 32586: Reindent items with no checkouts report template The indentation in the template was off and also full of tab characters, so this does some clean-up prior to doing some other small changes on separate bugs. To test: * Run the 'Items with no checkouts' report in the report module * Note: If you get an error in this step, you need to turn of sql_strict_mode in your koha-conf.xml, but this bug is out of scope here. * Apply patch * Rerun the report, it should appear unchanged Signed-off-by: Frédéric Demians <f.demians@tamil.fr> → Nice to the eyes, and no regression Created attachment 145858 [details] [review] Bug 32586: Reindent items with no checkouts report template The indentation in the template was off and also full of tab characters, so this does some clean-up prior to doing some other small changes on separate bugs. To test: * Run the 'Items with no checkouts' report in the report module * Note: If you get an error in this step, you need to turn of sql_strict_mode in your koha-conf.xml, but this bug is out of scope here. * Apply patch * Rerun the report, it should appear unchanged Signed-off-by: Frédéric Demians <f.demians@tamil.fr> → Nice to the eyes, and no regression Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> No regressions found, nice cleanup. Passing QA Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. Doesn't apply cleanly to 22.05.x, no backport |