Bug 32616

Summary: Add 'page-section' to various acquisitions pages
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: david, matt.blenkinsop, testopia
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.02
Circulation function:
Bug Depends on: 30952    
Bug Blocks: 31757    
Attachments: Bug 32616: Add 'page-section' to various acquisitions pages
Bug 32616: Add 'page-section' to various acquisitions pages
Bug 32616: Add 'page-section' to various acquisitions pages
Bug 32616: Add 'page-section' to various acquisitions pages

Description Owen Leonard 2023-01-12 16:51:53 UTC
Several acquisitions templates need to have main content wrapped in a "page-section" container.

 - acqui/edi_ean.tt
 - acqui/edifactmsgs.tt
 - acqui/histsearch.tt
 - acqui/lateorders.tt
 - acqui/newordersubscription.tt
 - acqui/newordersuggestion.tt
 - acqui/ordered.tt
 - acqui/spent.tt
 - acqui/z3950_search.tt
Comment 1 Owen Leonard 2023-01-12 17:11:18 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-01-12 18:02:24 UTC
Created attachment 145241 [details] [review]
Bug 32616: Add 'page-section' to various acquisitions pages

This patch adds a "page-section" container div around the main section
of acquisitions page which lack it.

This patch contains indentation changes, so please ignore whitespace
when looking at the diff.

To test, apply the patch and view the following pages to confirm that
the main content is contained in a white box:

- Acquisitions -> Vendor -> Basket -> Create EDIFACT order
- Acquisitions -> EDIFACT messages
- Acquisitions -> Orders search -> Results
- Acquisitions -> Late orders
- Acquisitions -> Vendor -> Add to basket -> From a subscription
- Acquisitions -> Vendor -> Add to basket -> From a suggestion
- Acquisitions -> All available funds -> Ordered
- Acquisitions -> All available funds -> Spent
- Acquisitions -> Vendor -> Add to basket -> From an external source ->
  Results
Comment 3 David Nind 2023-01-12 21:29:46 UTC
Created attachment 145247 [details] [review]
Bug 32616: Add 'page-section' to various acquisitions pages

This patch adds a "page-section" container div around the main section
of acquisitions page which lack it.

This patch contains indentation changes, so please ignore whitespace
when looking at the diff.

To test, apply the patch and view the following pages to confirm that
the main content is contained in a white box:

- Acquisitions -> Vendor -> Basket -> Create EDIFACT order
- Acquisitions -> EDIFACT messages
- Acquisitions -> Orders search -> Results
- Acquisitions -> Late orders
- Acquisitions -> Vendor -> Add to basket -> From a subscription
- Acquisitions -> Vendor -> Add to basket -> From a suggestion
- Acquisitions -> All available funds -> Ordered
- Acquisitions -> All available funds -> Spent
- Acquisitions -> Vendor -> Add to basket -> From an external source ->
  Results

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-01-12 21:31:55 UTC
Testing notes (using KTD):

1. EDIFACT setup:
   . Enable EDIFACT
   . Administration > Acquisition parameters:
     - EDI accounts > New account > Add details (including 'Orders enabled', details don't need to be valid)
     - Library EANs > New EAN

2. Suggestions: add a suggestion and change the status to accepted

3. Add to order from a subscription: set up a serial first
Comment 5 Katrin Fischer 2023-01-16 19:37:05 UTC
Created attachment 145338 [details] [review]
Bug 32616: Add 'page-section' to various acquisitions pages

This patch adds a "page-section" container div around the main section
of acquisitions page which lack it.

This patch contains indentation changes, so please ignore whitespace
when looking at the diff.

To test, apply the patch and view the following pages to confirm that
the main content is contained in a white box:

- Acquisitions -> Vendor -> Basket -> Create EDIFACT order
- Acquisitions -> EDIFACT messages
- Acquisitions -> Orders search -> Results
- Acquisitions -> Late orders
- Acquisitions -> Vendor -> Add to basket -> From a subscription
- Acquisitions -> Vendor -> Add to basket -> From a suggestion
- Acquisitions -> All available funds -> Ordered
- Acquisitions -> All available funds -> Spent
- Acquisitions -> Vendor -> Add to basket -> From an external source ->
  Results

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Katrin Fischer 2023-01-16 19:38:23 UTC
Tiny note/question: 

On the EDIFACT messages page there is a page-section with a dialog box within:

There are no EDIFACT messages.

On other pages we have the alerts/dialogs outside the page section. Maybe we should move this above the page section and make sure the empty page section doesn't display?
Comment 7 Martin Renvoize (ashimema) 2023-01-17 09:40:42 UTC
Nice work everyone!

Pushed to 23.05.x for the next release
Comment 8 Matt Blenkinsop 2023-01-17 15:00:41 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 9 Matt Blenkinsop 2023-01-17 15:11:48 UTC
Nice work everyone!

Pushed to stable for 22.11.x