| Summary: | Auth.t failing on D10 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | arthur.suzuki, jacob.omara, lucas, martin.renvoize, wainuiwitikapark |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.05.00, 22.11.02, 22.05.09, 21.11.16
|
|
| Circulation function: | |||
| Bug Depends on: | 31908 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 32622: Fix Auth.t on D10
Bug 32622: Fix Auth.t on D10 |
||
Hey, it's D10, sorry! Created attachment 145262 [details] [review] Bug 32622: Fix Auth.t on D10 It's caused by a version mismatch of Test::MockModule with D10, which does not have this commit: https://github.com/geofffranks/test-mockmodule/commit/fef9e742e45e2437e3449eea9970d70555d44bff We should remove the chaining here. Test plan: Confirm that Auth.t still pass, and is fixed on D10 Nice work Joubu! Created attachment 145270 [details] [review] Bug 32622: Fix Auth.t on D10 It's caused by a version mismatch of Test::MockModule with D10, which does not have this commit: https://github.com/geofffranks/test-mockmodule/commit/fef9e742e45e2437e3449eea9970d70555d44bff We should remove the chaining here. Test plan: Confirm that Auth.t still pass, and is fixed on D10 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works perfectly, Passing QA I'm a Muppet.. I forgot to update bugzilla that this is in master too... [U+1F600] Backported to 22.05.x for upcoming 22.05.09 pushed to 21.11.x for 21.11.16 Not backported to 21.05.x |
Caught by Jenkins 15:08:08 koha_1 | # Failed test 'While still logged in, relogin with another user' 15:08:08 koha_1 | # at t/db_dependent/Auth.t line 219. 15:08:08 koha_1 | # Looks like you planned 7 tests but ran 6. 15:08:08 koha_1 | # Looks like you failed 1 test of 6 run. 15:08:08 koha_1 | 15:08:08 koha_1 | # Failed test 'checkauth() tests' 15:08:08 koha_1 | # at t/db_dependent/Auth.t line 331. 15:08:08 koha_1 | Can't locate object method "mock" via package "0" (perhaps you forgot to load "0"?) at t/db_dependent/Auth.t line 176. The code is: t/db_dependent/Auth.t 175 my $mock2 = Test::MockModule->new('CGI') ->mock( 'request_method', 'POST' ) 176 ->mock( 'cookie', sub { return $sessionID; } ); # oversimplified.. It's caused by a version mismatch of Test::MockModule with D8, which does not have this commit: https://github.com/geofffranks/test-mockmodule/commit/fef9e742e45e2437e3449eea9970d70555d44bff We could remove the chaining, or... deactivate D8 builds, which should have been already done actually :)