Summary: | Use template wrapper for basket groups tabs | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | lucas, testopia |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
23.05.00,22.11.03
|
|
Circulation function: | |||
Bug Depends on: | 32571 | ||
Bug Blocks: | |||
Attachments: |
Bug 32660: Use template wrapper for basket groups tabs
Bug 32660: (follow-up) Use more unique variable name to avoid collisions Bug 32660: Use template wrapper for basket groups tabs Bug 32660: (follow-up) Use more unique variable name to avoid collisions Bug 32660: Use template wrapper for basket groups tabs Bug 32660: (follow-up) Use more unique variable name to avoid collisions |
Description
Owen Leonard
2023-01-17 19:42:04 UTC
Created attachment 145371 [details] [review] Bug 32660: Use template wrapper for basket groups tabs This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the basket groups page. To test you must have at least one active vendor, one or more closed baskets under that vendor, and at least one basket group containing a closed basket. Apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should see two tabs, "Open" and "Closed." The tabs should look correct and work correctly. Created attachment 145538 [details] [review] Bug 32660: (follow-up) Use more unique variable name to avoid collisions Created attachment 145790 [details] [review] Bug 32660: Use template wrapper for basket groups tabs This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the basket groups page. To test you must have at least one active vendor, one or more closed baskets under that vendor, and at least one basket group containing a closed basket. Apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should see two tabs, "Open" and "Closed." The tabs should look correct and work correctly. Signed-off-by: David Nind <david@davidnind.com> Created attachment 145791 [details] [review] Bug 32660: (follow-up) Use more unique variable name to avoid collisions Signed-off-by: David Nind <david@davidnind.com> Created attachment 146204 [details] [review] Bug 32660: Use template wrapper for basket groups tabs This patch implements the template WRAPPER system (see Bug 32571) for building tabs on the basket groups page. To test you must have at least one active vendor, one or more closed baskets under that vendor, and at least one basket group containing a closed basket. Apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should see two tabs, "Open" and "Closed." The tabs should look correct and work correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 146205 [details] [review] Bug 32660: (follow-up) Use more unique variable name to avoid collisions Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.05. Nice work everyone, thanks! Nice work, thanks everyone! Pushed to 22.11.x for the next release. |